Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new CI step for lint validation #4903

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Add new CI step for lint validation #4903

merged 6 commits into from
Jul 18, 2022

Conversation

shijiesheng
Copy link
Contributor

What changed?

Add a new CI step to validate code is linted.

Why?

commands like make go-generate could be ignored and cause the build to fail. The new CI step aims to address such issues.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0182121f-b911-4a66-a6e7-2020803693b1

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 73 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.009%) to 57.737%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/reconciliation/invariant/collection_enumer.go 0 1 0.0%
service/worker/scanner/executions/scantype_enumer.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.75%
common/membership/hashring.go 2 83.54%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.03%
service/history/execution/mutable_state_util.go 2 36.14%
service/history/task/transfer_active_task_executor.go 2 71.41%
common/persistence/dataManagerInterfaces.go 3 58.9%
service/history/queue/timer_gate.go 3 95.83%
common/types/mapper/thrift/shared.go 4 63.75%
service/history/task/transfer_standby_task_executor.go 8 87.18%
Totals Coverage Status
Change from base Build 0181d5e0-475a-4e8c-abb3-eb4952984e85: -0.009%
Covered Lines: 83686
Relevant Lines: 144943
💛 - Coveralls

@shijiesheng shijiesheng mentioned this pull request Jul 18, 2022
Closed
@shijiesheng shijiesheng enabled auto-merge (squash) July 18, 2022 18:45
@shijiesheng shijiesheng merged commit 25e221b into uber:master Jul 18, 2022
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request Jul 21, 2022
@shijiesheng @abhishekj720
Add new CI step for lint validation (uber#4903)
6072a77 
* fix lint error

* add new CI step for lint

* commit change after lint

* add missing dependency of makefile rule

* address comments: remove excessive artifact paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shijiesheng @coveralls @davidporter-id-au