Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint error #4902

Closed
wants to merge 2 commits into from
Closed

Fix Lint error #4902

wants to merge 2 commits into from

Conversation

shijiesheng
Copy link
Contributor

What changed?

Some fields in internal proto files doesn't conform to requirements, so they are added to exceptions for field-snake-case check.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jul 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 0182126b-88e4-45b7-9362-8dd812f980c1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.06%) to 57.739%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
service/history/queue/timer_queue_processor_base.go 1 77.26%
common/persistence/historyManager.go 2 66.67%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build 01820554-8b82-4cbc-907b-cc3a1d8e9ad8: 0.06%
Covered Lines: 83819
Relevant Lines: 145168
💛 - Coveralls

@shijiesheng
Copy link
Contributor Author

merged into #4903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shijiesheng @coveralls