Move MustCompile out (#3081)

uber · Nov 16, 2022 · 7778e81 · 7778e81
1 parent 4699ae3
commit 7778e81
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/common/persistence/elasticsearch/esVisibilityStore.go b/common/persistence/elasticsearch/esVisibilityStore.go
@@ -515,6 +515,8 @@ var (
 	}
 )
 
+var missingStartTimeRegex = regexp.MustCompile(jsonMissingStartTime)
+
 func getESQueryDSLForScan(request *p.ListWorkflowExecutionsByQueryRequest) (string, error) {
 	sql := getSQLFromListRequest(request)
 	dsl, err := getCustomizedDSLFromSQL(sql, request.DomainUUID)
@@ -631,8 +633,7 @@ func replaceQueryForOpen(dsl *fastjson.Value) *fastjson.Value {
 // ES v6 only accepts "must_not exists" query instead of "missing" query, but elasticsql produces "missing",
 // so use this func to replace.
 func replaceQueryForUninitialized(dsl *fastjson.Value) *fastjson.Value {
-	re := regexp.MustCompile(jsonMissingStartTime)
-	newDslStr := re.ReplaceAllString(dsl.String(), `{"bool":{"must_not":{"exists":{"field":"StartTime"}}}}`)
+	newDslStr := missingStartTimeRegex.ReplaceAllString(dsl.String(), `{"bool":{"must_not":{"exists":{"field":"StartTime"}}}}`)
 	dsl = fastjson.MustParse(newDslStr)
 	return dsl
 }