Non-blocking submit for Task Scheduler #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Feb 27, 2020
common/task/fifoTaskScheduler.go
Outdated
| func (f *fifoTaskSchedulerImpl) Submit(task PriorityTask) error { | ||
| func (f *fifoTaskSchedulerImpl) TrySubmit( | ||
| task PriorityTask, | ||
| ) (bool, error) { | ||
| f.metricsScope.IncCounter(metrics.ParallelTaskSubmitRequest) | ||
| sw := f.metricsScope.StartTimer(metrics.ParallelTaskSubmitLatency) |
There was a problem hiding this comment.
Do you want to differentiate the block and non-block methods latency?
There was a problem hiding this comment.
Removed latency metric from non-blocking method. And Request metric is emitted only when the task is actually submitted.
yux0
approved these changes
Feb 27, 2020
neil-xie
added a commit
that referenced
this pull request
Nov 1, 2022
…nt of uninitialized wf execution records (#3081)
neil-xie
added a commit
that referenced
this pull request
Nov 1, 2022
…nt of uninitialized wf execution records (#3081)
neil-xie
added a commit
that referenced
this pull request
Nov 16, 2022
neil-xie
added a commit
that referenced
this pull request
Nov 16, 2022
…nt of uninitialized wf execution records (#3081)
neil-xie
added a commit
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.