Run docker build on commits, to prevent docker build from breaking in…

… the future (#4978)

.buildkite/pipeline-pull-request.yml

@@ -152,3 +152,12 @@ steps:
       - docker-compose#v3.0.0:
           run: coverage-report
           config: docker/buildkite/docker-compose.yml
+
+  - label: ":docker: build (no push)"
+    agents:
+      queue: "workers"
+      docker: "*"
+    command: "scripts/buildkite/docker-build.sh"
+    retry:
+      automatic:
+        limit: 1

scripts/buildkite/docker-build.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -ex
+
+echo "Building docker images for $BUILDKITE_MESSAGE"
+
+docker build . -f Dockerfile -t ubercadence/server:master --build-arg TARGET=server
+docker build . -f Dockerfile -t ubercadence/server:master-auto-setup --build-arg TARGET=auto-setup
+docker build . -f Dockerfile -t ubercadence/cli:master --build-arg TARGET=cli
+docker build . -f Dockerfile -t ubercadence/cadence-bench:master --build-arg TARGET=bench
+docker build . -f Dockerfile -t ubercadence/cadence-canary:master --build-arg TARGET=canary

scripts/buildkite/docker-push.sh

@@ -18,19 +18,11 @@ if [ "$BUILDKITE_COMMIT" != "$MASTER_SHA" ]; then
     exit 0
 fi
 
-echo "Building docker image for $BUILDKITE_MESSAGE"
+scripts/buildkite/docker-build.sh
 
-docker build . -f Dockerfile -t ubercadence/server:master --build-arg TARGET=server
+echo "Pushing docker images for $BUILDKITE_MESSAGE"
 docker push ubercadence/server:master
-
-docker build . -f Dockerfile -t ubercadence/server:master-auto-setup --build-arg TARGET=auto-setup
 docker push ubercadence/server:master-auto-setup
-
-docker build . -f Dockerfile -t ubercadence/cli:master --build-arg TARGET=cli
 docker push ubercadence/cli:master
-
-docker build . -f Dockerfile -t ubercadence/cadence-bench:master --build-arg TARGET=bench
 docker push ubercadence/cadence-bench:master
-
-docker build . -f Dockerfile -t ubercadence/cadence-canary:master --build-arg TARGET=canary
 docker push ubercadence/cadence-canary:master