Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docker build on commits, to prevent docker build from breaking in the future #4978

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Run docker build on commits, to prevent docker build from breaking in the future #4978

merged 1 commit into from
Aug 27, 2022

Conversation

ZackLK
Copy link
Contributor

@ZackLK ZackLK commented Aug 27, 2022

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0182dcca-f3d4-40f1-96f8-c21dde5e54d1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 221 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.07%) to 57.77%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
service/matching/matcher.go 1 91.06%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_util.go 2 36.14%
service/history/handler.go 2 47.17%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 57.89%
common/task/fifoTaskScheduler.go 3 84.54%
Totals Coverage Status
Change from base Build 0182dcb0-8995-4eb9-980b-1cc8b8963dba: -0.07%
Covered Lines: 84335
Relevant Lines: 145984
💛 - Coveralls

@ZackLK ZackLK marked this pull request as ready for review August 27, 2022 02:43
davidporter-id-au
davidporter-id-au approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@ZackLK ZackLK merged commit 854fc59 into master Aug 27, 2022
@ZackLK ZackLK deleted the run_docker_build_on_commit branch August 27, 2022 02:55
@Groxx
Copy link
Contributor

Groxx commented Aug 31, 2022

ooh. yeah, great idea and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZackLK @coveralls @Groxx @davidporter-id-au