remove glibc hacks and update Zig SDK #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
motiejus
requested changes
Apr 11, 2023
| @@ -24,14 +24,14 @@ URL_FORMAT_NIGHTLY = "https://ziglang.org/builds/zig-{host_platform}-{version}.{ | |||
| # generous enough to host the artifacts, which we use. | |||
| URL_FORMAT_BAZELMIRROR = "https://mirror.bazel.build/" + URL_FORMAT_NIGHTLY.lstrip("https://") | |||
|
|
|||
| _VERSION = "0.11.0-dev.1796+c9e02d3e6" | |||
| _VERSION = "0.11.0-dev.2545+311d50f9d" | |||
There was a problem hiding this comment.
This needs to be also updated in mirror.bazel.build. Here is a mirror request from the past: bazelbuild/bazel#17635
motiejus@mtwork:~$ curl -I https://ziglang.org/builds/zig-linux-x86_64-0.11.0-dev.2545+311d50f9d.tar.xz
HTTP/2 200
content-type: application/x-xz
content-length: 44252188
date: Tue, 11 Apr 2023 10:02:54 GMT
x-amz-meta-s3cmd-attrs: atime:1681201277/ctime:1681200608/gid:1000/gname:ci/md5:89a67c9f8df75eeb80955cb553892a28/mode:33188/mtime:1681200608/uid:1000/uname:ci
cache-control: public, max-age=31536000, immutable
last-modified: Tue, 11 Apr 2023 08:21:49 GMT
etag: "857fe2f62b85b683d745714a4e6ce423-3"
server: AmazonS3
x-cache: Hit from cloudfront
via: 1.1 2fe761c42f710dbc97bfbe41f450bf42.cloudfront.net (CloudFront)
x-amz-cf-pop: ARN54-C1
x-amz-cf-id: o-IURQdV21K7WCei88sd0ahhyYIRulBB-q-6sKcF9IO7dBm2GvqOow==
age: 3948
motiejus@mtwork:~$ curl -I https://mirror.bazel.build/ziglang.org/builds/zig-linux-x86_64-0.11.0-dev.2545+311d50f9d.tar.xz
HTTP/2 404
x-guploader-uploadid: ADPycds1gh-8QsfM3gq0d11VQFRAWdVltRSoc9lzSTtMMR6XgCp3UBbOwQlBheQaSkDFzr9wqA-0l8atFi0C-CG_gEB-sQ
content-type: application/xml; charset=UTF-8
content-length: 127
date: Tue, 11 Apr 2023 11:08:46 GMT
expires: Tue, 11 Apr 2023 11:08:46 GMT
cache-control: private, max-age=0
server: UploadServer
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
motiejus@mtwork:~$
|
Very timely, thanks for opening this PR! :) I was hitting this again just now. |
|
Content is now mirrored :) |
|
Thanks for this. As mentioned in #33, I will need a few days to get this merged (there are some prerequisites which you will see popping in to the repository soon). |
motiejus
approved these changes
Apr 24, 2023
motiejus
added a commit
to motiejus/hermetic_cc_toolchain
that referenced
this pull request
Apr 24, 2023
This was missed in uber#30
|
Thanks! |
motiejus
added a commit
to motiejus/hermetic_cc_toolchain
that referenced
this pull request
Apr 24, 2023
This was missed in uber#30
motiejus
added a commit
that referenced
this pull request
May 15, 2023
This will check that the zig artifact that we are referring to is
mirrored correctly.
Test (after replacing `x86_64` with `x86_65` for the sake of this test):
checking if git tree is ready for the release
checking if zig is mirorred in "https://mirror.bazel.build/ziglang.org/builds/zig-windows-x86_65-0.11.0-dev.2619+bd3e248c7.zip"
error: zig is correctly mirrored: got non-200: 404 Not Found
Fixes #58
Refs #30
Merged
motiejus
added a commit
that referenced
this pull request
May 15, 2023
This will check that the zig artifact that we are referring to is
mirrored correctly.
Test (after replacing `x86_64` with `x86_65` for the sake of this test):
checking if git tree is ready for the release
checking if zig is mirorred in "https://mirror.bazel.build/ziglang.org/builds/zig-windows-x86_65-0.11.0-dev.2619+bd3e248c7.zip"
error: zig is correctly mirrored: got non-200: 404 Not Found
Fixes #58
Refs #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ziglang/zig#15101 is merged, I've removed the "glibc hacks" and updated the SDK to a snapshot where glibc < 2.28 works out of the box.
I kept the
//test/glibc_hackstest as a regression test.This fixes #29