Re-add linkopts and set -Wl,-headerpad_max_install_names on macos #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you. Let's wait until #30 is merged (probably EOW or beginning of next week) and then rebase. I will then properly review it. I am OK with |
|
If glibc-hacks is going away, would you like me to just remove that bit from this PR? |
That works too. |
|
Alright, I dropped that second commit. It should just be the headerpad change now. |
|
Sorry for the delay and all the stuff that piled up. Would you mind rebasing? |
Done! |
motiejus
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building artifacts for macos, pass the
-Wl,-headerpad_max_install_nameslinker option to leave space for modifying things likerpath.The built-in toolchain also does it here.
Also fixed an issue where the
.mapfiles underglibc-hacksweren't being included in the list of toolchain files.