Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os-release's "VERSION_CODENAME" to populate the right distro name in the apt source list #18

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mikaelarguedas
Copy link
Contributor

This allows to build images for Ubuntu 24.04 by passing --build-arg DEB_DISTRO=noble


Without this change building with --build-arg noble results in:

3.972 The following packages have unmet dependencies:
4.025  ros-one-rosbag : Depends: libboost-regex1.74.0-icu70 but it is not installable
4.025                   Depends: ros-one-rosbag-storage but it is not going to be installed
4.025  ros-one-rosconsole : Depends: libboost-regex1.74.0-icu70 but it is not installable
4.025                       Depends: liblog4cxx12 (>= 0.12.1) but it is not installable
4.025  ros-one-rospack : Depends: libpython3.10 (>= 3.10.0) but it is not installable
4.025                    Depends: libtinyxml2-9 (>= 8.0.0) but it is not installable
4.026 E: Unable to correct problems, you have held broken packages.
------
Dockerfile:31
--------------------
  30 |     # install ros packages
  31 | >>> RUN apt-get update && apt-get install -y --no-install-recommends \
  32 | >>>     ros-one-ros-core \
  33 | >>>     && rm -rf /var/lib/apt/lists/*
  34 |     
--------------------

…nd not jammy

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@rhaschke rhaschke merged commit 9add020 into ubi-agni:main Nov 12, 2024
@rhaschke
Copy link
Member

Thanks for pointing this out!

@mikaelarguedas mikaelarguedas deleted the fix_os_parametrization branch November 12, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants