-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong linked PR is closed on /stop
#4
Comments
Interesting that this problem persisted in both versions. I assumed this logic was rewritten from scratch |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|
[ 7.09 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.48 |
Review | Comment | 7 | 6.61 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu… | 1.6content: p: count: 16 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.3 | 0.48 |
I always open up my pull body with "Resolves #0". Are we sure th… | 2.6content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.6 | 1.56 |
Seems unusual that you added this directive. I suppose it doesn'… | 2.9content: p: count: 29 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.2 | 0.58 |
This enabled stuff should be removed. | 0.6content: p: count: 6 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.1 | 0.06 |
Can you demonstrate how the config would look if you wanted to d… | 1.7content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.4 | 0.68 |
This doesn't seem right. Configuration merging should be at the … | 4.6content: p: count: 39 score: 1 code: count: 7 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.2 | 0.92 |
Ideally we should have support for all the above scenarios. Cros… | 3.4content: p: count: 34 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.8 | 2.72 |
After my comments are addressed I'm okay to merge. | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.1 | 0.09 |
[ 17.1 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 17.1 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/… | 17.10000000000000228content: p: count: 53 score: 1 a: count: 2 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 3 | 1 | 17.1 |
[ 0 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 22 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Why are these ignored? | 0.4content: p: count: 4 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```suggestion const userToUnassign = assignees.fin… | 1.8content: p: count: 9 score: 1 code: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
The problem I noticed with this, is that in our issue template w… | 4.2content: p: count: 40 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```suggestion ``` | 0.2content: p: count: 1 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
You are correct I put plural by accident, singular makes sense. | 1.1content: p: count: 11 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I meant that the `prBody` would be like: ```… | 3content: p: count: 23 score: 1 code: count: 7 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Are these actually used? Is knip actually running on this branch… | 2.6content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
This issue also exists in other repos sadly. | 0.8content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Isn't the logger supposed to also generate the diff? | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
If the `main` is not recognized possibly some files will… | 3.3content: p: count: 32 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I think a quick fix that would be reliable is to remove comment,… | 3content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
It does resolve it properly wherever it is located, except HTML … | 1.7content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng So in the end are these needed? | 0.8content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng Yes but these dependencies are actually never imported … | 2.9content: p: count: 28 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
This is the recommended format from [the docs](https://typescrip… | 5.1content: p: count: 46 score: 1 a: count: 2 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I guess this was to mimic the v1 that actually had a field to di… | 2.7content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Currently, the repo configuration will override the organization… | 5.3content: p: count: 52 score: 1 a: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
No. If it is enabled organization level, it will be enabled in e… | 4.9content: p: count: 47 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Yes, implemented [here for example](https://github.com/ubiquibot… | 0.8content: p: count: 5 score: 1 a: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```yml plugins: # any plugin you want except com… | 3.7content: p: count: 28 score: 1 code: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
The thing is the id is arbitrary, and not even required. Plus, e… | 12.9content: p: count: 98 score: 1 code: count: 31 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng Yes, the merge issue is unrelated to this and will be a… | 2.2content: p: count: 22 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
[ 0 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 22 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Why are these ignored? | 0.4content: p: count: 4 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```suggestion const userToUnassign = assignees.fin… | 1.8content: p: count: 9 score: 1 code: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
The problem I noticed with this, is that in our issue template w… | 4.2content: p: count: 40 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```suggestion ``` | 0.2content: p: count: 1 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
You are correct I put plural by accident, singular makes sense. | 1.1content: p: count: 11 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I meant that the `prBody` would be like: ```… | 3content: p: count: 23 score: 1 code: count: 7 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Are these actually used? Is knip actually running on this branch… | 2.6content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
This issue also exists in other repos sadly. | 0.8content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Isn't the logger supposed to also generate the diff? | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
If the `main` is not recognized possibly some files will… | 3.3content: p: count: 32 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I think a quick fix that would be reliable is to remove comment,… | 3content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
It does resolve it properly wherever it is located, except HTML … | 1.7content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng So in the end are these needed? | 0.8content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng Yes but these dependencies are actually never imported … | 2.9content: p: count: 28 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
This is the recommended format from [the docs](https://typescrip… | 5.1content: p: count: 46 score: 1 a: count: 2 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
I guess this was to mimic the v1 that actually had a field to di… | 2.7content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Currently, the repo configuration will override the organization… | 5.3content: p: count: 52 score: 1 a: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
No. If it is enabled organization level, it will be enabled in e… | 4.9content: p: count: 47 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Yes, implemented [here for example](https://github.com/ubiquibot… | 0.8content: p: count: 5 score: 1 a: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
```yml plugins: # any plugin you want except com… | 3.7content: p: count: 28 score: 1 code: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
The thing is the id is arbitrary, and not even required. Plus, e… | 12.9content: p: count: 98 score: 1 code: count: 31 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
@Keyrxng Yes, the merge issue is unrelated to this and will be a… | 2.2content: p: count: 22 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 1.6 |
Review | Comment | 2 | 4.4 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu... | 1.6 | 0.71 | 1.6 |
> I think there may be legitimate scenarios where a PR exists... | 3.4 | 0.74 | 3.4 |
After my comments are addressed I'm okay to merge.... | 1 | 0.78 | 1 |
[ 2.3 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 1 | 2.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@Keyrxng Yes, the merge issue is unrelated to this and will be a... | 2.3 | 0.535 | 2.3 |
[ 80.8 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 4 | 27.9 |
Review | Comment | 4 | 27.9 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.7 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.7 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.745 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.74 | 1 |
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.7 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.7 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.745 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.74 | 1 |
[ 18.6 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 18.6 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/... | 18.6a: count: 2 score: "2" words: 2 li: count: 2 score: "2" words: 13 code: count: 2 score: "2" words: 5 | 1 | 18.6 |
Seems to be a little formatting issue, will open a ticket about it. |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 19 | 271.2 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Resolves https://github.com/ubiquibot/command-start-stop/issues/… | 0content: p: count: 4 score: 1 ul: count: 73 score: 0 li: count: 73 score: 1 pre: count: 21 score: 0 code: count: 21 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.9 | - |
https://github.com/ubiquibot/command-start-stop/pull/10#issuecom… | 6.8content: p: count: 17 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 6.8 |
Should we use a plural when it only returns a singular user? and… | 12.4content: p: count: 30 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 12.4 |
hmm, the `"pull_request" in source` check should elimina… | 25.2content: p: count: 60 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 25.2 |
I see my mistake, if this confirmation via PR body is the way to… | 11.6content: p: count: 29 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 11.6 |
the workflow runs on `pull_request_target` and the actio… | 17.2content: p: count: 40 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 17.2 |
what do you suggest then, avoid using this sort of approach all … | 9.2content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 9.2 |
I forgot about that @gentlementlegen [QA](https://github.com/u… | 2.8content: p: count: 6 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 2.8 |
Solved for html comments but even still I expect to see some tee… | 14content: p: count: 35 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 14 |
resolved | 0.4content: p: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 0.4 |
@gentlementlegen https://github.com/ubiquibot/command-start-stop… | 8.8content: p: count: 20 score: 1 a: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 8.8 |
Ah I was on auto-pilot thinking they were in the action entry bu… | 6.4content: p: count: 16 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 6.4 |
I disagree. How can we disable it on specific repos with this re… | 9.2content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 9.2 |
So it would be active globally via the org and if there is no co… | 23.6content: p: count: 59 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 23.6 |
Right okay I'm following so far. So the pattern we've been usi… | 27.6content: p: count: 62 score: 1 code: count: 6 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 27.6 |
I think a new task if required is the way to go. Correct me if… | 20content: p: count: 50 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 20 |
I want to add that even with the example in the PR body it would… | 44.8content: p: count: 110 score: 1 code: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 44.8 |
I've added the PR body check I referenced the issue from anothe… | 27.2content: p: count: 68 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 27.2 |
just double checking that we are good to merge here | 4content: p: count: 10 score: 1 wordValue: 0.2 formattingMultiplier: 2 | 1 | 4 |
[ 21.48 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.48 |
Review | Comment | 8 | 21 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu… | 1.6content: p: count: 16 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.3 | 0.48 |
I always open up my pull body with "Resolves #0". Are we sure th… | 2.6content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 2.6 |
Seems unusual that you added this directive. I suppose it doesn'… | 2.9content: p: count: 29 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 2.9 |
This enabled stuff should be removed. | 0.6content: p: count: 6 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 0.6 |
Can you demonstrate how the config would look if you wanted to d… | 1.7content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 1.7 |
This doesn't seem right. Configuration merging should be at the … | 3.8content: p: count: 32 score: 1 pre: count: 6 score: 0 code: count: 6 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 3.8 |
The bot has access to private repositories. Using the bot authen… | 5.1content: p: count: 51 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 5.1 |
Ideally we should have support for all the above scenarios. Cros… | 3.4content: p: count: 34 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 3.4 |
After my comments are addressed I'm okay to merge. | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 0.9 |
[ 14.69 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.065 |
Review | Comment | 22 | 14.625 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Seems to be a little formatting issue, will open a ticket about … | 0.325content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 0.2 | 0.065 |
Why are these ignored? | 0.1content: p: count: 4 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.1 |
```suggestion const userToUnassign = assignees.fi… | 0.2content: pre: count: 8 score: 0 code: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
The problem I noticed with this, is that in our issue template w… | 1.05content: p: count: 40 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.05 |
```suggestion ``` | 0.025content: pre: count: 1 score: 0 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.025 |
You are correct I put plural by accident, singular makes sense. | 0.275content: p: count: 11 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.275 |
I meant that the `prBody` would be like: ```… | 0.6content: p: count: 17 score: 1 code: count: 7 score: 1 pre: count: 6 score: 0 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.6 |
Are these actually used? Is knip actually running on this branc… | 0.65content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.65 |
This issue also exists in other repos sadly. | 0.2content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
Isn't the logger supposed to also generate the diff? | 0.225content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.225 |
If the `main` is not recognized possibly some files will… | 0.825content: p: count: 32 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.825 |
I think a quick fix that would be reliable is to remove comment,… | 0.75content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.75 |
It does resolve it properly wherever it is located, except HTML … | 0.425content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.425 |
@Keyrxng So in the end are these needed? | 0.2content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
@Keyrxng Yes but these dependencies are actually never imported … | 0.725content: p: count: 28 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.725 |
This is the recommended format from [the docs](https://typescrip… | 1.275content: p: count: 46 score: 1 a: count: 2 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.275 |
I guess this was to mimic the v1 that actually had a field to di… | 0.675content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.675 |
Currently, the repo configuration will override the organization… | 1.325content: p: count: 52 score: 1 a: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.325 |
No. If it is enabled organization level, it will be enabled in e… | 1.225content: p: count: 47 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.225 |
Yes, implemented [here for example](https://github.com/ubiquibot… | 0.2content: p: count: 5 score: 1 a: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
```yml plugins: # any plugin you want except c… | 0.675content: pre: count: 8 score: 0 code: count: 8 score: 1 p: count: 19 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.675 |
The thing is the id is arbitrary, and not even required. Plus, e… | 2.45content: p: count: 68 score: 1 pre: count: 29 score: 0 code: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 2.45 |
@Keyrxng Yes, the merge issue is unrelated to this and will be a… | 0.55content: p: count: 22 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.55 |
[ 16.5 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 16.5 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/… | 16.5content: p: count: 38 score: 1 a: count: 2 score: 1 code: count: 2 score: 1 ul: count: 13 score: 0 li: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 3 | 1 | 16.5 |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 1.6 |
Review | Comment | 2 | 4.4 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu... | 1.6 | 0.49 | 1.6 |
> I think there may be legitimate scenarios where a PR exists... | 3.4 | 0.73 | 3.4 |
After my comments are addressed I'm okay to merge.... | 1 | 0.79 | 1 |
[ 3.6 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 1.3 |
Review | Comment | 1 | 2.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Seems to be a little formatting issue, will open a ticket about ... | 1.3 | 0.44 | 1.3 |
@Keyrxng Yes, the merge issue is unrelated to this and will be a... | 2.3 | 0.585 | 2.3 |
[ 80.8 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 4 | 27.9 |
Review | Comment | 4 | 27.9 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.73 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.735 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.745 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.745 | 1 |
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.73 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.735 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.745 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.745 | 1 |
[ 18.6 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 18.6 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/... | 18.6a: count: 2 score: "2" words: 2 li: count: 2 score: "2" words: 13 code: count: 2 score: "2" words: 5 | 1 | 18.6 |
@gentlementlegen the assignee should not be eligible for review rewards. I assume our config supports this already. Can you make the necessary adjustments for both organizations and link the commits here? |
+ Evaluating results. Please wait... |
@Keyrxng the deadline is at 2024-08-15T09:58:09.949Z |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 19 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Resolves https://github.com/ubiquibot/command-start-stop/issues/… | 0content: p: count: 4 score: 1 ul: count: 73 score: 0 li: count: 73 score: 1 pre: count: 21 score: 0 code: count: 21 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.9 | - |
https://github.com/ubiquibot/command-start-stop/pull/10#issuecom… | 0content: p: count: 17 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
Should we use a plural when it only returns a singular user? and… | 0content: p: count: 30 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
hmm, the `"pull_request" in source` check should elimina… | 0content: p: count: 60 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I see my mistake, if this confirmation via PR body is the way to… | 0content: p: count: 29 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
the workflow runs on `pull_request_target` and the actio… | 0content: p: count: 40 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
what do you suggest then, avoid using this sort of approach all … | 0content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I forgot about that @gentlementlegen [QA](https://github.com/u… | 0content: p: count: 6 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
Solved for html comments but even still I expect to see some tee… | 0content: p: count: 35 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
resolved | 0content: p: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
@gentlementlegen https://github.com/ubiquibot/command-start-stop… | 0content: p: count: 20 score: 1 a: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
Ah I was on auto-pilot thinking they were in the action entry bu… | 0content: p: count: 16 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I disagree. How can we disable it on specific repos with this re… | 0content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
So it would be active globally via the org and if there is no co… | 0content: p: count: 59 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
Right okay I'm following so far. So the pattern we've been usi… | 0content: p: count: 62 score: 1 code: count: 6 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I think a new task if required is the way to go. Correct me if… | 0content: p: count: 50 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I want to add that even with the example in the PR body it would… | 0content: p: count: 110 score: 1 code: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
I've added the PR body check I referenced the issue from anothe… | 0content: p: count: 68 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
just double checking that we are good to merge here | 0content: p: count: 10 score: 1 wordValue: 0.2 formattingMultiplier: 0 | 1 | - |
[ 22.11 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 1.11 |
Review | Comment | 8 | 21 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu… | 1.6content: p: count: 16 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.5 | 0.8 |
@gentlementlegen the assignee should not be eligible for review… | 3.1content: p: count: 31 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.1 | 0.31 |
I always open up my pull body with "Resolves #0". Are we sure th… | 2.6content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 2.6 |
Seems unusual that you added this directive. I suppose it doesn'… | 2.9content: p: count: 29 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 2.9 |
This enabled stuff should be removed. | 0.6content: p: count: 6 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 0.6 |
Can you demonstrate how the config would look if you wanted to d… | 1.7content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 1.7 |
This doesn't seem right. Configuration merging should be at the … | 3.8content: p: count: 32 score: 1 pre: count: 6 score: 0 code: count: 6 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 3.8 |
The bot has access to private repositories. Using the bot authen… | 5.1content: p: count: 51 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 5.1 |
Ideally we should have support for all the above scenarios. Cros… | 3.4content: p: count: 34 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 3.4 |
After my comments are addressed I'm okay to merge. | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 0.9 |
[ 14.75 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 0.125 |
Review | Comment | 22 | 14.625 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Seems to be a little formatting issue, will open a ticket about … | 0.325content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 0.2 | 0.065 |
@0x4007 So you mean that Keyrxng here should have had `0`… | 0.6content: h2: count: 15 score: 1 code: count: 3 score: 1 p: count: 4 score: 1 a: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 0.1 | 0.06 |
Why are these ignored? | 0.1content: p: count: 4 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.1 |
```suggestion const userToUnassign = assignees.fi… | 0.2content: pre: count: 8 score: 0 code: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
The problem I noticed with this, is that in our issue template w… | 1.05content: p: count: 40 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.05 |
```suggestion ``` | 0.025content: pre: count: 1 score: 0 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.025 |
You are correct I put plural by accident, singular makes sense. | 0.275content: p: count: 11 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.275 |
I meant that the `prBody` would be like: ```… | 0.6content: p: count: 17 score: 1 code: count: 7 score: 1 pre: count: 6 score: 0 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.6 |
Are these actually used? Is knip actually running on this branc… | 0.65content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.65 |
This issue also exists in other repos sadly. | 0.2content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
Isn't the logger supposed to also generate the diff? | 0.225content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.225 |
If the `main` is not recognized possibly some files will… | 0.825content: p: count: 32 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.825 |
I think a quick fix that would be reliable is to remove comment,… | 0.75content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.75 |
It does resolve it properly wherever it is located, except HTML … | 0.425content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.425 |
@Keyrxng So in the end are these needed? | 0.2content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
@Keyrxng Yes but these dependencies are actually never imported … | 0.725content: p: count: 28 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.725 |
This is the recommended format from [the docs](https://typescrip… | 1.275content: p: count: 46 score: 1 a: count: 2 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.275 |
I guess this was to mimic the v1 that actually had a field to di… | 0.675content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.675 |
Currently, the repo configuration will override the organization… | 1.325content: p: count: 52 score: 1 a: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.325 |
No. If it is enabled organization level, it will be enabled in e… | 1.225content: p: count: 47 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 1.225 |
Yes, implemented [here for example](https://github.com/ubiquibot… | 0.2content: p: count: 5 score: 1 a: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.2 |
```yml plugins: # any plugin you want except c… | 0.675content: pre: count: 8 score: 0 code: count: 8 score: 1 p: count: 19 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.675 |
The thing is the id is arbitrary, and not even required. Plus, e… | 2.45content: p: count: 68 score: 1 pre: count: 29 score: 0 code: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 2.45 |
@Keyrxng Yes, the merge issue is unrelated to this and will be a… | 0.55content: p: count: 22 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 1 | 0.55 |
[ 16.5 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 16.5 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/… | 16.5content: p: count: 38 score: 1 a: count: 2 score: 1 code: count: 2 score: 1 ul: count: 13 score: 0 li: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 3 | 1 | 16.5 |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 41.7 |
Review | Comment | 2 | 4.4 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Interesting that this problem persisted in both versions. I assu... | 1.6 | - | 1.6 |
> <details> <summary> <b> ... | 40.1a: count: 8 score: "8" words: 12 code: count: 29 score: "29" words: 201 | - | 40.1 |
> I think there may be legitimate scenarios where a PR exists... | 3.4 | 0.71 | 3.4 |
After my comments are addressed I'm okay to merge.... | 1 | 0.815 | 1 |
[ 10.5 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 8.2 |
Review | Comment | 1 | 2.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Seems to be a little formatting issue, will open a ticket about ... | 1.3 | - | 1.3 |
@0x4007 So you mean that Keyrxng here should have had `0`... | 6.9a: count: 2 score: "2" words: 2 code: count: 2 score: "2" words: 3 hr: count: 1 score: "1" words: 0 | - | 6.9 |
@Keyrxng Yes, the merge issue is unrelated to this and will be a... | 2.3 | 0.515 | 2.3 |
[ 80.8 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 4 | 27.9 |
Review | Comment | 4 | 27.9 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.7 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.76 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.68 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.7 | 1 |
> Cross org indeed is rare. If its too complicated then perha... | 5.4 | 0.7 | 5.4 |
I want to add that even with the example in the PR body it would... | 13.2code: count: 1 score: "1" words: 2 | 0.76 | 13.2 |
I've added the PR body checkI referenced the issue from anot... | 8.3 | 0.68 | 8.3 |
just double checking that we are good to merge here... | 1 | 0.7 | 1 |
[ 18.6 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 18.6 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquibot/command-start-stop/pull/... | 18.6a: count: 2 score: "2" words: 2 li: count: 2 score: "2" words: 13 code: count: 2 score: "2" words: 5 | 1 | 18.6 |
@0x4007 Is that what you intended? |
Okay let's see how relevance scoring works. Perhaps I am biased but I am expecting something closer to v1 scoring, just because I fine tuned its config over some months to get what I think kind of makes sense. Let's run this again once that capability is merged in. |
Depends on #1
Check this
/stop
command. The bot (i.e.ubiquibot/command-start-stop
plugin) closed the issue but also tried to close a linked PR although this PR is from a different repo with different assignee.What should be done:
The text was updated successfully, but these errors were encountered: