Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge development into main #131

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Merge development into main #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ebcb41
chore: update husky install script
gentlementlegen Oct 11, 2024
758145b
fix: update eslint ignores
gentlementlegen Oct 11, 2024
f30d361
refactor: remove custom Husky install script
gentlementlegen Oct 11, 2024
ca08e9f
fix: update husky to version 9.1.6
gentlementlegen Oct 11, 2024
9a76d37
fix: update Husky setup for production and CI
gentlementlegen Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ permissions:
contents: write
pull-requests: write

env:
HUSKY: 0

jobs:
release-please:
runs-on: ubuntu-latest
Expand All @@ -29,11 +32,8 @@ jobs:

- name: Build
run: |
bun install -p --frozen-lockfile
bun install --frozen-lockfile
bun sdk:build
env:
# Disables Husky globally
HUSKY: 0
if: ${{ steps.release.outputs.release_created }}
- run: bun publish --access public
env:
Expand Down
8 changes: 8 additions & 0 deletions .husky/install.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// Skip Husky install in production and CI
// https://typicode.github.io/husky/how-to.html#ci-server-and-docker
if (process.env.NODE_ENV === "production" || process.env.CI === "true") {
console.log("Skipping Husky install because of production environment.");
process.exit(0);
}
const husky = (await import("husky")).default;
console.log(husky());
Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default tsEslint.config({
"@typescript-eslint": tsEslint.plugin,
"check-file": checkFile,
},
ignores: [".github/knip.ts", "**/.wrangler/**", "jest.config.ts"],
ignores: [".github/knip.ts", "**/.wrangler/**", "jest.config.ts", ".husky/**"],
extends: [eslint.configs.recommended, ...tsEslint.configs.recommended, sonarjs.configs.recommended],
languageOptions: {
parser: tsEslint.parser,
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"format:lint": "eslint --fix .",
"format:prettier": "prettier --write .",
"format:cspell": "cspell **/*",
"prepare": "husky install",
"prepare": "node .husky/install.mjs",
"deploy-dev": "wrangler deploy --env dev",
"deploy-production": "wrangler deploy --env production",
"worker": "wrangler dev --env dev --port 8787",
Expand Down Expand Up @@ -94,7 +94,7 @@
"eslint-plugin-check-file": "2.8.0",
"eslint-plugin-prettier": "5.1.3",
"eslint-plugin-sonarjs": "1.0.3",
"husky": "9.0.11",
"husky": "9.1.6",
"knip": "5.26.0",
"lint-staged": "15.2.7",
"npm-run-all": "4.1.5",
Expand Down
Loading