Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: an error occurred when running make run-ui #152

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

plpycoin
Copy link
Contributor

@plpycoin plpycoin commented Nov 7, 2024

ENV:

$ node --version
v18.20.4

$ npm --version
10.7.0

Err Info:

./src/components/Output.tsx:254:43
Type error: Type '{ children: Element; source: string; className: string; }' is not assignable to type 'IntrinsicAttributes & BookmarkableTextProps'.
  Property 'className' does not exist on type 'IntrinsicAttributes & BookmarkableTextProps'.

  252 |         </div>
  253 |       ) : outputs.length > 0 ? (
> 254 |         <BookmarkableText source="output" className="h-full">
      |                                           ^
  255 |           <ResizableDataTable
  256 |             data={outputs}
  257 |             columns={columns}
./src/components/ResizableDataTable.tsx:240:5
Type error: Object literal may only specify known properties, and 'onColumnSizingStart' does not exist in type 'TableOptions<T>'.

  238 |       },
  239 |     },
> 240 |     onColumnSizingStart: () => setIsResizing(true),
      |     ^
  241 |     onColumnSizingEnd: () => debouncedSetIsResizing(false),
  242 |   });
  243 |

 * className attribute issue
 * compatibility issue of the latest version of @tanstack/react-table
@shreyashankar
Copy link
Collaborator

thanks for catching this! LGTM on my end

@shreyashankar shreyashankar merged commit 241d27a into ucbepic:main Nov 7, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants