Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: an error occurred when running make run-ui #152

Merged
merged 2 commits into from
Nov 7, 2024
Merged

hotfix: an error occurred when running make run-ui #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46cbe3
hotfix:
lapsule Nov 7, 2024
c800541
Merge branch 'main' of github.com:plpycoin/docetl
lapsule Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion website/src/components/BookmarkableText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { useToast } from "@/hooks/use-toast";
interface BookmarkableTextProps {
children: React.ReactNode;
source: string;
className?: string;
}

const formSchema = z.object({
Expand All @@ -42,6 +43,7 @@ const formSchema = z.object({
const BookmarkableText: React.FC<BookmarkableTextProps> = ({
children,
source,
className = "overflow-y-auto"
}) => {
const [buttonPosition, setButtonPosition] = useState({ x: 0, y: 0 });
const [showButton, setShowButton] = useState(false);
Expand Down Expand Up @@ -137,7 +139,7 @@ const BookmarkableText: React.FC<BookmarkableTextProps> = ({
ref={textRef}
onMouseUp={handleMultiElementSelection}
onTouchEnd={handleMultiElementSelection}
className="overflow-y-auto"
className={className}
>
{children}
{showButton && (
Expand Down
6 changes: 3 additions & 3 deletions website/src/components/ResizableDataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ function ResizableDataTable<T extends DataType>({
getPaginationRowModel: getPaginationRowModel(),
onColumnSizingChange: (newColumnSizing) => {
setColumnSizing(newColumnSizing);
setIsResizing(true);
debouncedSetIsResizing(false);
saveSettings();
},
onColumnVisibilityChange: setColumnVisibility,
Expand All @@ -236,9 +238,7 @@ function ResizableDataTable<T extends DataType>({
pagination: {
pageSize: 5,
},
},
onColumnSizingStart: () => setIsResizing(true),
onColumnSizingEnd: () => debouncedSetIsResizing(false),
}
});

return (
Expand Down
Loading