Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes sure .eslintrc included in eslint-config-obojobo package #1603

Merged

Conversation

iturgeon
Copy link
Member

@iturgeon iturgeon commented Oct 23, 2020

.eslintrc is used in the other packages, so this makes sure that the npm packages that get .eslintrc from this package will be able to find it.

zachberry
zachberry previously approved these changes Jan 22, 2021
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to do what it says on the tin

@zachberry zachberry changed the base branch from dev/15-magnetite to dev/16-connemara-marble January 22, 2021 21:25
@zachberry zachberry dismissed their stale review January 22, 2021 21:25

The base branch was changed.

zachberry
zachberry previously approved these changes Jan 22, 2021
@zachberry zachberry added this to the 17 - Peridot milestone Feb 5, 2021
@jpeterson976 jpeterson976 changed the base branch from dev/16-connemara-marble to dev/17-peridot February 15, 2021 20:28
@jpeterson976 jpeterson976 dismissed zachberry’s stale review February 15, 2021 20:28

The base branch was changed.

Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated base branch to dev17. Still seems to work as advertised.

@zachberry zachberry merged commit fec40d0 into ucfopen:dev/17-peridot Feb 15, 2021
@iturgeon iturgeon mentioned this pull request Mar 16, 2021
@iturgeon iturgeon deleted the issue/add-eslintrc-to-npm-package branch January 30, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants