Dev/17 peridot #1681
Merged
Dev/17 peridot #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work on embed code
…rt and stop for youtube modal
… work on embed code
…rt and stop for youtube modal
…e and youtube url now gets processed on blur
We had an outage where our AWS RDS database failed over to its backup server. Normally one would expect the db driver to lose connection or at least somehow be aware of the outage. It wasn't, and just sat waiting for every db query to resolve. No errors logged, no automatic recovery. The node proccesses needed to be terminated to re-establish connections. This commit adds query_timeouts to the configuration for pg-promise to ensure that they will eventually time out. We set them just below chromes usual request timeout to maximize the time before timeout occurs. This should give us a lot of headroom for unforseen long-running queries and still produce error logs we can use to indicate something has gone wrong. Important: adds a required env var: DB_TIMEOUT, suggested value 29000
…ndly Issue/1234 youtube user friendly
makes sure .eslintrc included in eslint-config-obojobo package
query timeouts added
…essment Rectified how highest attempts are marked
Clearer message for assessment ID error
Restrict allowed characters in id
…ction-issue Triple-clicking selection issue
github test action optimization
upgrade katex from 0.11.1 to 0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generated by running
hub pr list --base dev/17-peridot --state closed --format "- [#%I](%U) - %t%n"