Dev/19 serendibite #1747
Merged
Dev/19 serendibite #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: if you use the dev dashboard to launch a student view in a new tab, it'll launch that tab without switching focus to it. Once you switch to that tab, obo thinks you must have left and come back, so the code tries to send a return event - with a reference to a non-existent leave event. This commit adds a new event to represent the first time the module is visible to the student. It will increase timing accuracy and prevent the error thats currently being thrown due to an undefined leave event reference.
…into issue/1275-duplicate-figures
…into issue/1275-duplicate-figures
The idea here is to let the figure be duplicated when a node is inserted in the caption, then take the duplicated figure (which will be 2 lines below) and convert it to a text node.
…to issue/1275-duplicate-figures
…to issue/1275-duplicate-figures
…ring * Color Picker custom color icon only updates when a valid color is inputted * Inputting "" will remove any color content * The swatch for the color of the selected text will be highlighted, if it exists * Color Picker opens in expanded mode if an expanded or custom color was chosen * Hitting enter in the custom color text input submits the color and closes the dialog (does not work in FF) * Some small CSS tweaks * Updated the Expand button to use $color-action-bg, also updated the Link Menu to use this as well * Repositioned the color input control to take up the same location as the color icon, resulting in the color input control to show up near the icon * Added a keyboard shortcut - Meta+Shift+P * Moved the color picker toolbar button to the right
…to issue/1275-duplicate-figures
… and allows you to hit enter
…/1449-first-visit-and-return-events
…/1449-first-visit-and-return-events
…/1449-first-visit-and-return-events
…urn-events adds viewer:initialView event and fixes opening in a new tab
Fix splitting figures
…rue) when the color menu is open, fixing the issue with the math equation dialog to close * Changes the latex input to a textarea
…-window-disappearing Fix MathEquation edit dialog disappearing in dev/19
* Forces caption width to image-width when size is large or medium
…'t work for large and medium images
…-update Figure caption width in tutorial
The method we use to build the docker image requires obo chunks to rely on eachother by using peerDepenencies instead of dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
hub pr list --base dev/19-serendibite --state closed --format "- [#%I](%U) - %t%n"