Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons Missing in Footer and other areas #161

Closed
haitzlm opened this issue Nov 16, 2022 · 1 comment · Fixed by #199
Closed

Icons Missing in Footer and other areas #161

haitzlm opened this issue Nov 16, 2022 · 1 comment · Fixed by #199
Assignees
@haitzlm
Labels
bug Something isn't working dependencies Pull requests that update a dependency file UI/UX

Comments

@haitzlm
Copy link
Contributor

haitzlm commented Nov 16, 2022 •
edited
Loading

Edit: not just footer
Font Awesome icons not showing in footer, and also in "edit" view of submissions:
missing-font
@haitzlm haitzlm changed the title Footer - Social Media Icons Icons Missing in Footer and other areas Nov 16, 2022
@haitzlm
Copy link
Contributor Author

haitzlm commented Nov 16, 2022 •
edited
Loading

The path to font awesome in our code is:

<script src="https://kit.fontawesome.com/a076d05399.js"></script>

If one tries to access that script, you get an error:
Not allowed when Origin missing
So I think font awesome is not loading correctly, due to cross browser restrictions. There is a gem for font awesome:

@hortongn hortongn mentioned this issue Sep 6, 2023
Closed
@hortongn hortongn added the UI/UX label Sep 6, 2023
@hortongn hortongn added this to the Next deploy milestone Sep 11, 2023
@haitzlm haitzlm self-assigned this Sep 11, 2023
haitzlm added a commit that referenced this issue Sep 11, 2023
@haitzlm
fixes #161-fontawesome icons
0d0a592
@haitzlm haitzlm mentioned this issue Sep 11, 2023
Merged
Janell-Huyck added a commit that referenced this issue Sep 12, 2023
@Janell-Huyck
Merge pull request #199 from uclibs/fix-fontawesome
0e6a7e5 
fixes #161-fontawesome icons
Janell-Huyck added a commit that referenced this issue Sep 18, 2023
@Janell-Huyck
Merge pull request #199 from uclibs/fix-fontawesome
3592241 
fixes #161-fontawesome icons
@Janell-Huyck Janell-Huyck mentioned this issue Sep 18, 2023
Closed
@Janell-Huyck Janell-Huyck added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 12, 2023
@hortongn hortongn removed this from the Next deploy milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haitzlm haitzlm

Labels
bug Something isn't working dependencies Pull requests that update a dependency file UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #161-fontawesome icons uclibs/aaec
3 participants
@haitzlm @hortongn @Janell-Huyck