fixes #161-fontawesome icons #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
This is working well. Good find, getting that new URL for font awesome icons!
Normally I would suggest not leaving the old URL in place when making a change like this. If we really need it for something, we can find it in the GIT history, and leaving extra comments just clutters up the file. This may be a matter of style and group norms that I haven't run across yet.
Images of the Font Awesome icons showing up correctly in the footer and the admin page:
Janell-Huyck
added a commit
that referenced
this pull request
Sep 18, 2023
fixes #161-fontawesome icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161 ; refs #161
*Was not able to test missing icons in admin area...