283 - Refactor publications_controller#show #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #338 updated the #show function to make it more robust for testing purposes. |
Janell-Huyck
deleted the
refactor-283-publications-controller-show-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
This PR just aims to improve the readability of the PublicationsController's
showmethod.Note - the usage of helpers.find_submitter() required a submitter id, which our "show" tests had not been providing. So the tests have been updated to include a submitter_id in their valid params. In the app, a submitter_id is provided in the forms via a hidden field tag like this:
<%= hidden_field_tag "book[submitter_id]", session[:submitter_id] || @book.submitter_id %>