Add more comprehensive testing for publications controller #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
hortongn
reviewed
Feb 12, 2024
There was a problem hiding this comment.
@Janell-Huyck This all looks great. I appreciate the comments you included. My only suggestion is a spec for #show that verifies @submitter is getting set properly for an admin session. Push back if you think that's covered in other ways.
|
That's a good idea. @submitter and @submitters is getting set differently for admins and submitters in this logic. I'll get a check on that and let you know when I'm ready for a re-check. |
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
337-detailed-tests-for-publications-controller
branch
2 times, most recently
from
47c5d4a
to
0faee0a
Compare
Janell-Huyck
force-pushed
the
337-detailed-tests-for-publications-controller
branch
from
0faee0a
to
bb85d37
Compare
Janell-Huyck
changed the title
Janell-Huyck
changed the title
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
337-detailed-tests-for-publications-controller
branch
from
31a8a7a
to
ea56fd3
Compare
Janell-Huyck
force-pushed
the
337-detailed-tests-for-publications-controller
branch
from
ea56fd3
to
926f982
Compare
hortongn
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@Janell-Huyck Looks great. Thanks for refactoring PublicationsController#show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #337
This PR gives more comprehensive testing for the PublicationsController. It is the first PR for issue #337. Later PRs will involve creating a superficial CRUD testing shared examples for the different publication types and removing the redundant testing for those controllers.
Since we do not have a Publications model, and since all of the publication types inherit their CRUD methods directly from the parent controller, we are testing the PublicationsController through its direct child controller, BooksController. We are testing for user authentication and the Create, Index, Update, and Destroy methods defined in PublicationsController.
The file spec/support/helpers/login_helpers_for_unit_tests.rb was created in PR #323, but as that has not been merged in at the time of the PR creation, I have recreated it here in this PR. I've added a
login_as_adminmethod in the helper and added a line that will log out any admin user from an admin role when they are logging in as a submitter of a work.