Issue 430: Add top-level class and requirements on node identifiers #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a find-and-replace to reset the value of `sh:nodeKind` in SHACL constraints, only done within the scope of the UCO ontology files. The non-UCO shapes files (i.e. for Collections Ontology, OWL) are intentionally left unaffected by this change, to allow for interoperability with non-UCO content using those ontologies' concepts. A follow-on patch will regenerate Make-managed files. This patch will fail CI from the adjusted constraint. A further follow-on patch will correct the unit tests (separated as demonstration of impact). References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will regenerate Make-managed files. References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch is known to fail CI due to the new test. It is posted early for definition-comment feedback. References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This is in preparation of an expansion of the class of disjoint subclasses of core:UcoThing. Note that per the OWL 2 to RDF mapping document, an `owl:AllDisjointClasses` declaration must have a blank node as its subject. References: * #430 * https://www.w3.org/TR/2012/REC-owl2-mapping-to-rdf-20121211/ Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
No effects were observed on Make-managed files. References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Note that usage of prefixes in the core namespace does not require the ontology corresponding to the namespace must be imported. Class declarations are provided for each of the disjoint class members due to the UCO Core namespace requiring the ability to be valid OWL on its own. The classes need to be declared in satisfaction of these rules from the OWL 2 to RDF parsing (table row numbers start their counts at 1): * Section 3.2.1: For any OWL mapping function f(x), "f(x) = ε" means "f is not defined at x." * Table 16, row 10: The expression "CE(y_i) ≠ ε" reads as "The class expression function must be defined for the input y_i." * Table 9, row 1: See also the preamble text immediately preceding within Section 3.2.1, describing that CE(x) is initialized to ε for all x. * Section 3.2.1 also requires that CE(x) is defined at most once. Once defined, "no attempt should be made to change the function's value for x." (Hence, a later assignment to the same value doesn't qualify as a re-definition.) * Table 7, row 1 and Table 16, row 1 both handle mapping `*:x rdf:type owl:Class .` into the OWL structural specification. * The triple `*:x rdf:type owl:Class .` is required within the transitive closure of the ontology being parsed (i.e. the collection of all ontologies brought in via `owl:imports`). This is supported in part by Section 3.1.1, and also by order of much of the subtractive, consumptive parsing process being unimportant, so long as the entire graph is consumed by the parsing process (see the last sentence before section 4: "At the end of this process, the graph G must be empty." Because the UCO Core namespace imports no other UCO namespaces, it must include the class declarations from other UCO namespaces to support being OWL-parsed by itself. References: * #430 * https://www.w3.org/TR/2012/REC-owl2-mapping-to-rdf-20121211/ Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will correct the new unit test failures across all examples. References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will generate the Make-managed file. References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * #430 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Closed
14 tasks
ajnelson-nist
force-pushed
the
Feature-Issue-430
branch
from
40ab04a to
19094fd
Compare
ajnelson-nist
force-pushed
the
Feature-Issue-430
branch
from
902e9eb to
ad6d62b
Compare
eoghanscasey
approved these changes
Sep 1, 2022
11 tasks
|
Thanks for the approval @eoghanscasey ! I'm going to wait until the |
Closed
14 tasks
ajnelson-nist
added a commit
to casework/CASE
that referenced
this pull request
Sep 1, 2022
References: * ucoProject/UCO#430 * ucoProject/UCO#467 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request will resolve all requirements of Issue #430 .
Coordination
unstablebranch (98ec576)unstablebranch tracking UCO'sunstableas submodule (db3fe86)