Bug fix 513 #514
Merged
Bug fix 513 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer. |
|
Alex,I will test it this afternoon - just so many piling-up tasks.v/r Ray
On Friday, January 13, 2023 at 03:13:16 PM EST, Alex Nelson ***@***.***> wrote:
@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi Alex,
I just completed the tests and the previous SHACL errors in UCO Shapes are gone.
The fix Bug-Fix-153 is good as my review results. The fixed UCO is very good now (no error using my (TopBraid lib to validate).
V/R Ray
On Friday, January 13, 2023 at 03:30:52 PM EST, Ray Sheu ***@***.***> wrote:
Alex,I will test it this afternoon - just so many piling-up tasks.v/r Ray
On Friday, January 13, 2023 at 03:13:16 PM EST, Alex Nelson ***@***.***> wrote:
@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@DrSnowbird Wonderful, thank you! We'll have this in the next release. |
ajnelson-nist
approved these changes
Jan 13, 2023
8 tasks
References: * #513 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to casework/CASE-Archive
that referenced
this pull request
Mar 10, 2023
No effects were observed on Make-managed files. References: * ucoProject/UCO#514 * ucoProject/UCO#516 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this pull request
Mar 15, 2023
No effects were observed on Make-managed files. References: * ucoProject/UCO#514 * ucoProject/UCO#516 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves all requirements of Issue #513 .
Coordination
developunstablebranch (b22d045)unstablebranch tracking UCO'sunstableas submodule (18fe007)