Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lambdas :) #725

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Support for lambdas :) #725

merged 3 commits into from
Dec 16, 2024

Conversation

AlecsFerra
Copy link
Contributor

No description provided.

Signed-off-by: Alessio Ferrarini <alessio.ferrarini@imdea.org>
@AlecsFerra
Copy link
Contributor Author

AlecsFerra commented Dec 12, 2024

This should be pretty definitive even if it's useless without the corresponding PR on LH

Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlecsFerra. A spot that could need more discussion are the changes to evalELam.

-- We need to refresh it as for some reason lamdba variables
-- as reflected lambdas variables for some reason are declared
-- two times, maybe we should define a new type of identifier
-- and not reuse the etabeta ones
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an example of what it means for a lambda variable to be reflected twice?

It looks like it would be worth investigating that, instead of changing the code here to workaround a possible bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why but if for example you take the SKILam and remove this branch it will complain that the variable name that is used by the lambdas is declared twice in the smt file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to reproduce this in a smaller example, but couldn't. But I think it is ok to investigate it separately.

@nikivazou nikivazou merged commit 48ea289 into ucsd-progsys:develop Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants