Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementor compatibility #560

Closed
ewsopp opened this issue Sep 25, 2020 · 3 comments
Closed

elementor compatibility #560

ewsopp opened this issue Sep 25, 2020 · 3 comments
Assignees
Milestone

Comments

@ewsopp
Copy link
Member

ewsopp commented Sep 25, 2020

It looks like there may be two problems with our elementor compatibility and the latest v3.0 release of wp-stateless.

  1. The uploaded CSS files don't have proper permissions set and are not publicly accessible.
  2. They are not stored in the correct /elementor/css/ directory. They are being uploaded into the root directory of the bucket.
@ewsopp ewsopp added this to the v3.0.4 milestone Sep 25, 2020
alimuzzaman pushed a commit that referenced this issue Sep 29, 2020
alimuzzaman pushed a commit that referenced this issue Sep 29, 2020
#560 elementor compatibility
alimuzzaman pushed a commit that referenced this issue Sep 29, 2020
#560 elementor compatibility
@ewsopp ewsopp assigned antonkorotkov and unassigned alimuzzaman Oct 1, 2020
alimuzzaman pushed a commit that referenced this issue Oct 4, 2020
antonkorotkov added a commit that referenced this issue Oct 5, 2020
@antonkorotkov antonkorotkov mentioned this issue Oct 5, 2020
@ewsopp
Copy link
Member Author

ewsopp commented Oct 10, 2020

@antonkorotkov did this fix the permission problem as well? The release notes only mention the location, and the problem with permissions was not mentioned.

In my original bug report above, the uploaded file permissions were not set to public.

A user just reported the problem, so it leads me to believe the permissions were not fixed. See https://wordpress.org/support/topic/elementor-css-files-have-been-synced-to-gcs-but-cannot-be-accessed-after-publis-2/

@antonkorotkov
Copy link
Contributor

@antonkorotkov did this fix the permission problem as well? The release notes only mention the location, and the problem with permissions was not mentioned.

In my original bug report above, the uploaded file permissions were not set to public.

A user just reported the problem, so it leads me to believe the permissions were not fixed. See https://wordpress.org/support/topic/elementor-css-files-have-been-synced-to-gcs-but-cannot-be-accessed-after-publis-2/

We could not replicate the permissions issue. We don't know the steps to reproduce it so we decided it was a temp problem with the API or something. Looks like it needs more attention.

@luckysistemi
Copy link

css files are now stored in the "elementor" folder at the root of the bucket.
I think it lacks a parameter to define the base folder for it or split "folder" option in two parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants