Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#560 elementor compatibility #562

Merged
merged 6 commits into from
Oct 5, 2020
Merged

#560 elementor compatibility #562

merged 6 commits into from
Oct 5, 2020

Conversation

alimuzzaman
Copy link
Contributor

No description provided.

@alimuzzaman alimuzzaman changed the base branch from v3.0 to latest September 29, 2020 13:18
@antonkorotkov antonkorotkov self-assigned this Sep 30, 2020
@antonkorotkov
Copy link
Contributor

@alimuzzaman Another issue found here. In Backup mode Elementor should upload files to GCS (as it does) but local files should be served instead. Right now it always tries to get the file from remote unless the mode is Disabled.

Copy link
Contributor

@antonkorotkov antonkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bug should be addressed #562 (comment)

@antonkorotkov
Copy link
Contributor

@alimuzzaman also, do we have an option to clean up the sm_sync table somehow? In my example, I have some orphaned data related to the files that do not exist any more. And they are being tried to sync every time I run manual sync. Only elementor/css/* files really exist after your fix but the old ones are still there. Do you think we can add a button of sorts to clear this table? Or it cannot be cleared?

image

@alimuzzaman
Copy link
Contributor Author

@antonkorotkov
If both file missing when doing manual sync we can remove the entry from the table.

Yes, we can add a button to clear the table. There shouldn't be any problem doing it. But should test in Stateless mode.

@antonkorotkov
Copy link
Contributor

antonkorotkov commented Sep 30, 2020

@antonkorotkov
If both file missing when doing manual sync we can remove the entry from the table.

Can you please implement this? If we do this we don't need a button.

Copy link
Contributor

@antonkorotkov antonkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thanks.

@antonkorotkov antonkorotkov merged commit 904f0b6 into latest Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants