Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider fonts #54

Closed
mirdaki opened this issue Oct 28, 2018 · 1 comment
Closed

Reconsider fonts #54

mirdaki opened this issue Oct 28, 2018 · 1 comment
Labels
CSS enhancement good first issue help wanted
Milestone
1.1.0

Comments

@mirdaki
Copy link
Member

mirdaki commented Oct 28, 2018 •
edited
Loading

We originally chose "Noto Sans" and "Noto Serif", because they seemed like a good pair. In practice certain things (like the header and footer) seem off.

Some new suggestions, particularity for the header and footer, but other things as well, would be appreciated.

Resource

  • Google fonts has a lot of options and will recommend some pairings
@mirdaki mirdaki added this to the 1.1.0 milestone Oct 28, 2018
@logandgsmith logandgsmith mentioned this issue Feb 1, 2019
Merged
mirdaki pushed a commit that referenced this issue Feb 3, 2019
@logandgsmith @mirdaki
New Fonts (#60)
594b8a9 
# Fixes

Replaces the Mono fonts with IBM Plex fonts.

## Related Issues

#54
@mirdaki
Copy link
Member Author

mirdaki commented Feb 3, 2019

Completed with #60

@mirdaki mirdaki closed this as completed Feb 3, 2019
mirdaki added a commit that referenced this issue Feb 17, 2019
@mirdaki
Patch 1.0.2 (#67)
5caa103 
* Update HTML and CSS for sign in to work more properly

- Added names and values to form elements (for the backend to read)
- Adjusted CSS to be more desirable to a sign in page

* Better alignment of sign-in form with flexbox

* Add JavaScript to communicate with backend for attendance

* updated logo-text.png

* Update links and resources to the new club repos

* New Fonts (#60)

# Fixes

Replaces the Mono fonts with IBM Plex fonts.

## Related Issues

#54

* Remove floats in topnav in favor of floats (#59)

* Removed topnav floats and replaced with flexbox

* Update about.css to fix list spacing (#61)

* Update about.css

Added more padding to OL

* Updated about.css

When reducing the grid-gap with a few px it solved the problem at least in Chrome and Internet Explorer. Not sure about Firefox. This may not be an ideal solution, so feel free to dismiss my these changes :)

* Justify li to not have weird number spacing

* Navbar on small screens, hover over content (#63)

* Navbar on small screens, hover over content

* removed empty div in navbar

* Remove topnav-placeholder everywhere and extra whitespace

* Fix for navbar links not hiding on mobile displays

Had to update a CSS specifier

* Add CREDITS.md file to give credit to other open source projects

* Update descriptions with link to the getting started guide

- Both in the about page and get involved section of the index page
- Also cleaned and implemented a lot of the TODOs

* Remove unfinshed pages before deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS enhancement good first issue help wanted
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@mirdaki