Navbar on small screens, hover over content #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if you need the div for anything. Do you want me to deleted it along with the styles, or just to comment out the height? |
|
I can't seem to find a reason for it, so if you could remove it and the styling (and do a double check to make sure it doesn't effect anything else haha), I'd appreciate it! |
|
I just pushed the changes to the same branch. Let me know how that is. |
|
This is great! The only changes I've made were to remove the topnav-placeholder from all of the other pages and some extra whitespace I found. Thank you so much for your help! We've been wanting to update this for a while. |
|
Forgot about the other pages lol. No problem, I am happy to help. |
mirdaki
added a commit
that referenced
this pull request
Feb 17, 2019
* Update HTML and CSS for sign in to work more properly - Added names and values to form elements (for the backend to read) - Adjusted CSS to be more desirable to a sign in page * Better alignment of sign-in form with flexbox * Add JavaScript to communicate with backend for attendance * updated logo-text.png * Update links and resources to the new club repos * New Fonts (#60) # Fixes Replaces the Mono fonts with IBM Plex fonts. ## Related Issues #54 * Remove floats in topnav in favor of floats (#59) * Removed topnav floats and replaced with flexbox * Update about.css to fix list spacing (#61) * Update about.css Added more padding to OL * Updated about.css When reducing the grid-gap with a few px it solved the problem at least in Chrome and Internet Explorer. Not sure about Firefox. This may not be an ideal solution, so feel free to dismiss my these changes :) * Justify li to not have weird number spacing * Navbar on small screens, hover over content (#63) * Navbar on small screens, hover over content * removed empty div in navbar * Remove topnav-placeholder everywhere and extra whitespace * Fix for navbar links not hiding on mobile displays Had to update a CSS specifier * Add CREDITS.md file to give credit to other open source projects * Update descriptions with link to the getting started guide - Both in the about page and get involved section of the index page - Also cleaned and implemented a lot of the TODOs * Remove unfinshed pages before deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Nav menu on small screens hovers over the content and is more concise.
I have kept the height of the empty div with a class of topnav-placeholder.
Related Issues