Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate BNU soil type data #717

Merged
merged 13 commits into from
Dec 1, 2022
Merged

Incorporate BNU soil type data #717

merged 13 commits into from
Dec 1, 2022

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Nov 29, 2022 •
edited
Loading

DESCRIPTION OF CHANGES:

Updates to create model grids using the new Beijing Normal Univ. soil type data.

TESTS CONDUCTED:

See below for details.

DEPENDENCIES:

None.

DOCUMENTATION:

Updated for new dataset. See: https://georgegayno-noaaufs-utils.readthedocs.io/en/feature-bnu_soil/ufs_utils.html#id57

ISSUE:

Fixes #705

GeorgeGayno-NOAA and others added 12 commits October 20, 2022 20:08
@GeorgeGayno-NOAA
Add program to read the raw bnu soil data on tiles, combine
bd91189 
them into a single global lat/lon grid, then write out the
result to a netcdf file readable by ufs_utils.

Fixes ufs-community#705.
@GeorgeGayno-NOAA
Update utility to output a NH subset file.
87b69dc 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Remove utility as the land group used its own processes
c984bfd 
to create this file.

Fixes ufs-community#705
@GeorgeGayno-NOAA
Update script comments for new soil type.
66ca305 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Update comments in sfc_climo_gen utility script.
94146f3 
Update documentation.

Fixes ufs-community#705.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/bnu_soil
ae26d52 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/bnu_soil
2660b1a 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Update ./ush/sfc_climo_gen.sh for user selected
4f835c0 
soil type file.

Fixes ufs-community#705.
@GeorgeGayno-NOAA
Update script comments.
ada42f6 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/bnu_soil
1876706 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Correct script comment.
3040461 
Fixes ufs-community#705.
@GeorgeGayno-NOAA
Correct script comment.
144c86b 
Fixes ufs-community#705.
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Dec 1, 2022
@GeorgeGayno-NOAA
Copy link
Collaborator Author

First, ensure these changes don't affect the current capability. The branch at 144c86b was compiled on Hera, Orion, Jet and WCOSS2 (Cactus). The grid_gen consistency tests were run. All tests passed.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

Next, create a grid(s) using the new BNU soil data. Using the branch at 144c86b, a regional ESG grid was created on Orion, Hera and Jet. On WCOSS2, regional ESG, global C96 and global C768 grids were created. All model grid soil type files were inspected visually and compared to the original data. All tests passed.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review December 1, 2022 14:44
barlage
barlage approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@barlage barlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look complete to me.

JeffBeck-NOAA
JeffBeck-NOAA reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgeGayno-NOAA, I see updates to the docs and driver scripts, but not to the code. How does the code know what to do with "bnu.30s"? Does it just search for whatever string is provided?

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA, I see updates to the docs and driver scripts, but not to the code. How does the code know what to do with "bnu.30s"? Does it just search for whatever string is provided?

The path/name of the soil type file is a namelist entry for sfc_climo_gen (input_soil_type_file in ./ush/sfc_climo_gen.sh). The program expects that this file has a 'soil_type' record, lat/lon records for geo-referencing, and a few attribute records. So as long as the soil type file contains these records, the program should work. For users that create grids using the scripts in ./driver_scripts, the soil type file is selected using the soil_type_src variable. I know that some groups do not use those scripts to create grids. So, you are welcome to run your own tests.

JeffBeck-NOAA
JeffBeck-NOAA approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @GeorgeGayno-NOAA. I think this looks good!

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit e0260ab into ufs-community:develop Dec 1, 2022
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/bnu_soil branch December 1, 2022 19:52
AnnetteGibbs-NOAA added a commit to AnnetteGibbs-NOAA/UFS_UTILS that referenced this pull request Jul 3, 2023
@AnnetteGibbs-NOAA
Merge remote-tracking branch 'origin/develop' into feature/dyn_dng
2286a16 
* origin/develop:
  Update ccpp submodule (ufs-community#827)
  Change length of character variable "mosaic_name" in "make_solo_mosaic.c" (ufs-community#824)
  Update GDAS INIT utility for GFS COM reorganization (ufs-community#820)
  Add backup calculation for orography and mask generation (ufs-community#713)
  Improve repository build script (ufs-community#819)
  Use latest wgrib2 executable on Jet. (ufs-community#816)
  chgres_cube - Minor update for high-resolution grids . (ufs-community#814)
  Update PR template (ufs-community#813)
  global_cycle - Add soil moisture nudging for NoahMP option (ufs-community#809)
  Release v1.10.0 (ufs-community#807)
  Run sfc_climo_gen utility on Hera (ufs-community#791)
  Fix bug in chgres_cube subroutine search_many (ufs-community#808)
  sfc_climo_gen - Output fractions of each vegetation/soil type category (ufs-community#748)
  Replace w3nco library with w3emc (ufs-community#802)
  Fix Debug compilation (ufs-community#800)
  Update WCOSS2 build module to use new ESMF v8.4.1 library. (ufs-community#799)
  Update chgres_cube documentation for duplicate grib2 records (ufs-community#795)
  Use latest Cray modules on WCOSS2 (ufs-community#792)
  Remove checksum attribute from global_cycle restart files (ufs-community#794)
  Remove goto statements from chgres_cube (ufs-community#775)
  FVCOM_TOOLS - Remove dependency on module_nwp_base.f90 (ufs-community#790)
  Remove "gcovr" step from the 'developer' workflow (ufs-community#785)
  Update build module for Cheyenne (ufs-community#783)
  GDAS Init utility - consolidate the copy of coldstart files (ufs-community#773)
  Remove support for ODIN machine (ufs-community#782)
  Update GDAS INIT utility to optionally use fracoro data (ufs-community#741)
  Option to build only application specific utilities (e.g. GFS) (ufs-community#777)
  Use combined IP/IP2 library (ufs-community#695)
  Initial updates to global_cycle for Noah-MP land model (ufs-community#774)
  New resolution options for the cpld_gridgen utility (ufs-community#769)
  Use new EPIC-maintained hpc-stack on Jet  (ufs-community#771)
  Update GDAS initialization scripts for the new ENKF directory (ufs-community#764)
  Reduce memory usage in chgres_cube (ufs-community#766)
  Detect duplicate vertical levels in chgres_cube. (ufs-community#767)
  Point to new input orography directory. (ufs-community#758)
  Release version 1.9 (ufs-community#754)
  HAFSv1 grid nesting updates (ufs-community#752)
  Remove compiler warnings from chgres_cube (ufs-community#747)
  chgres_cube: Split input_data module into to 3 separate modules (ufs-community#744)
  More work on CI, checking with different versions of ESMF (ufs-community#742)
  Add processing of soil color to sfc_climo_gen (ufs-community#721)
  more work on CI - added Linux_versions workflow (ufs-community#739)
  Add TEST_FILE_DIR option to CMake build, where test data files can be found instead of using FTP.  (ufs-community#732)
  adding developer workflow (ufs-community#724)
  Update GDAS INIT utility for v16.3. (ufs-community#723)
  OROG_GSL - Remove negative bias in orographic asymmetery (OA) fields (ufs-community#718)
  Incorporate BNU soil type data (ufs-community#717)
  High-resolution MODIS and STATSGO veg/soil data. (ufs-community#703)
  Run WCOSS2 consistency tests under role account (ufs-community#711)
  Fix macOS CI workflow (ufs-community#715)
  Add utility codes to create BNU soil texture data (ufs-community#707)
  Update chgres_cube to output netcdf4 file. (ufs-community#704)
  Incorporate high-res global VIIRS vegetation data. (ufs-community#699)
  Run grid_gen consistency tests in parallel. (ufs-community#697)
  Fix error handling in "link_fixdirs.sh". Add -L to the copy command. (ufs-community#701)
  Update for new fixed data directory structure (ufs-community#688)
  Add WCOSS2 support for tests (ufs-community#693)
  Increase test data pull timeout (ufs-community#692)
  Option to install binaries to any directory. (ufs-community#685)
  Update global_cycle to use the latest CCPP version of sfcsub.F (ufs-community#671)
  Incorporate weight_gen program. (ufs-community#677)
  Add install of jpeg-turbo to macos workflows (ufs-community#684)
  Improve logic in regression test driver script (ufs-community#681)
  Release v1.8 (ufs-community#679)
  Update link_fixdirs.sh for new data directories (ufs-community#672)
  Update default ice climatology in ./ush/global_cycle.sh. (ufs-community#664)
  Remove all references to WCOSS 1 from UFS_UTILS (ufs-community#667)
  Update workflows to use latest macOS and ubuntu (ufs-community#675)
  Update GDAS Initialization utility for recent HPSS tarball name change (ufs-community#666)
  Port UFS_UTILS to WCOSS2 (ufs-community#642)
  Fix chgres_cube to process GEFS GRIB2 data (ufs-community#658)
  Update global_cycle_driver.sh for GFS OPS directory convention  (ufs-community#655)
  Update documentation for SRW App (ufs-community#656)
  New coupled model utility (ufs-community#647)
  Update support for S4 and enable regression testing (ufs-community#654)
  global_cycle - Link to CCPP version of sfcsub.F (ufs-community#636)
  Add processing of new global AFWA snow data to emcsfc_snow2mdl. (ufs-community#648)
  Update build module on Cheyenne (ufs-community#646)
  Move to Intel 2022 on Jet, Hera and Orion (ufs-community#650)
  Host doxygen documentation for multiple releases (ufs-community#644)
  Download unit test data as part of the CMake build (ufs-community#630)
  chgres_cube - Complete removal of wgrib2 library (ufs-community#641)
  Eliminate circular dependency in chgres_cube
  Update workflow files to pull netcdf-c library from GitHub
  chgres_cube - Remove the wgrib2 library from the GRIB2 data read routines.
  Undefined symbols on macOS with Intel compiler (ufs-community#628)
  Update FVCOM code to handle sub-domain restart files using multiple cores. (ufs-community#624)
  chgres_cube - Run routine 'convert_omega' on all tasks. (ufs-community#627)
  Use ESMF 8.2.0 library
  Automate update of consistency test baseline data. (ufs-community#603)
  Update workflow files to use newer versions of ESMF and NCEPLIBS. (ufs-community#617)
  Update build modules to be lua compliant (ufs-community#614)
  Allow FVCOM tools to Update Ice Surface Roughness Length (ufs-community#604)
  Update the requested memory in the Orion chgres_cube consistency test script (ufs-community#611)
  Use copy of grib_util under Jet role account. (ufs-community#608)
  Run consistency tests on Orion using role account (ufs-community#606)
  Run consistency tests on Hera using role account (ufs-community#605)
  Run consistency tests on Jet using role account. (ufs-community#607)
  Update more documentation after move to ufs-community (ufs-community#597)
  fvcom_tools - Add option to process 'cold' or 'warm' restart files (ufs-community#595)
  Update documentation after move to ufs-community (ufs-community#594)
  chgres_cube - Eliminate segmentation fault in input_data.F90 (ufs-community#585)
  Update to language of unit test README to match that in unit test.
  chgres_cube - Simplify surface processing using field bundles (ufs-community#572)
  Add compiler flags for GNU Fortran v10 or newer compilers. (ufs-community#583)
  Move verbose output from example unit test to be commented to streamline test output.
  Updates to test README to add instructions for use of example unit test.
  Add Findwgrib2.cmake (ufs-community#578)
  Added unit test to be used as an instructional example for new users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@barlage barlage barlage approved these changes

@LarissaReames-NOAA LarissaReames-NOAA Awaiting requested review from LarissaReames-NOAA

Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate BNU soil type data
3 participants
@GeorgeGayno-NOAA @barlage @JeffBeck-NOAA