Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GFS diagnostic Aerosol Optical Depth (AOD) output to the exact 550nm #16

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

ChunxiZhang-NOAA
Copy link

This PR is opened on behalf of @zhanglikate. It aims to resolve the issue#15

@dustinswales dustinswales changed the title Adjust GFS diagnostic ADO output to the exact 550nm Adjust GFS diagnostic Aerosol Optical Depth (AOD) output to the exact 550nm Oct 26, 2022
@AnningCheng-NOAA
Copy link
Collaborator

looks fine with me. Approved.

@grantfirl
Copy link
Collaborator

I don't have any substantial comments, only coding style stuff, but it would be nice to address them before merging.

@ChunxiZhang-NOAA ChunxiZhang-NOAA merged commit 8c9d446 into ufs-community:ufs/dev Nov 14, 2022
@Qingfu-Liu Qingfu-Liu assigned Qingfu-Liu and unassigned Qingfu-Liu May 31, 2023
@Qingfu-Liu Qingfu-Liu self-requested a review May 31, 2023 11:39
Copy link
Collaborator

@Qingfu-Liu Qingfu-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

grantfirl pushed a commit that referenced this pull request Mar 18, 2024
correctly convert from flashes per five minutes to flashes per minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants