-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics #2
Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics #2
Conversation
Update to mraerosol branch from Dom
…_20211018 Anning mraerosol updates dom 20211018
@AnningCheng-NOAA @gthompsnWRF Please review this PR at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me. Approved
looks good and just approved.
…On Mon, Sep 26, 2022 at 10:39 AM ChunxiZhang-NOAA ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> @gthompsnWRF
<https://github.com/gthompsnWRF> Please review this PR at your
convenience.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIL6MPCCY4I2ON2ONT3WAGYRDANCNFSM6AAAAAAQOT3BBE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I did not run the tests, but the code changes look good to me.
@grantfirl @dustinswales Could you please review this PR again, thanks. |
I would like to suggest starting a new PR and a new issue to address these
changes, which might take more time than we expected and not really related
to coupling between aerosol and microphysics. This PR has been in the
queue for about a year and we do not want it to be overtaken by other PRs
again.
…On Tue, Sep 27, 2022 at 6:31 PM gthompsnWRF ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/module_mp_thompson.F90
<#2 (comment)>
:
> @@ -2188,7 +2214,7 @@ subroutine mp_thompson (qv1d, qc1d, qi1d, qr1d, qs1d, qg1d, ni1d, &
endif
nc(k) = MIN( DBLE(Nt_c_max), ccg(1,nu_c)*ocg2(nu_c)*rc(k) &
/ am_r*lamc**bm_r)
- if (.NOT. is_aerosol_aware) nc(k) = Nt_c
+ if (.NOT. (is_aerosol_aware .or. merra2_aerosol_aware)) nc(k) = Nt_c
All the calculations for nu_c and lamc should be internally consistent.
If not, then a bug was made somehow. I reviewed my WRF code and I've never
had a line resetting such as these IF-statements. I suppose I will have to
re-check the math, but nu_c is calculated from Nt_c, then lamc is
calculated and so the computations should be "circular" basically. The
division/multipication by rho could be something that got done as an
afterthought and introduced an error.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJFNDC2PAPG7472FWLWANX4HANCNFSM6AAAAAAQOT3BBE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@gthompsnWRF a comment was yesterday added as "In GOCART and MERRA2,
aerosols are given as mixing ratio (kg/kg). To convert from kg/kg to #/kg,
the "unit mass" (mass of one particle) within the mass bins is calculated.
A lognormal size distribution within aerosol bins is used to find the size
based upon the median mass. NIFA is mainly summarized over five dust bins
and NWFA over the other 10 bins. The parameters besides each bins are
carefully tuned for a good performance of the scheme. "
Please let me know if you have any suggestions.
…On Wed, Sep 28, 2022 at 6:32 PM gthompsnWRF ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/mp_thompson.F90
<#2 (comment)>
:
> @@ -846,4 +878,18 @@ subroutine mp_thompson_finalize(errmsg, errflg)
end subroutine mp_thompson_finalize
+ subroutine get_niwfa(aerfld, nifa, nwfa, ncol, nlev)
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> So then PLEASE
write a proper description as a comment. This is not a burden and this is a
huge help to those of us who know nothing about MERRA aerosols. The
community needs a proper description. I will adamantly refuse to accept the
PR if one is not included. It could still be merged by someone without a
description, but that would be shame.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJNBVJ4SRBZBJXT6K3WATBOBANCNFSM6AAAAAAQOT3BBE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@AnningCheng-NOAA I am seeking a bigger description, most importantly, as I indicated at the start, please indicate what are the constituents that represent the last index of the |
@chunxi zhang - NOAA Affiliate ***@***.***> , please add the
following description: The fields for the last index of the aerfld array
are specified as below. The units are micrometers. 1: dust bin1, 0.1 to 1;
2: dust bin2, 1 to 1.8; 3: dust bin3, 1.8 to 3.0; 4: dust bin 4, 3.0 to
6.0; 5: dust bin5, 6.0 to 10.0; 6: sea salt bin1, 0.03 to 0.1; 7: sea salt
bin2, 0.1 to 0.5; 8: sea salt bin3, 0.5 to 1.5; 9: sea salt bin4, 1.5 to
5.0; 10: sea salt bin5, 5.0 to 10.0; 11: Sulfate with mean 0.35; 15: water
friendly organic carbon with mean 0.35.
The density has a unit of kg per square meters. dust bin1: 2500; dust
bin2-5: 2650; sea salt all bins: 2200; sulfate: 1700; organic carbon: 1800.
Thank @gthompsnWRF <https://github.com/gthompsnWRF> for the specific
suggestions. Please let me know if you have any questions.
…On Thu, Sep 29, 2022 at 5:25 PM gthompsnWRF ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I am seeking a
bigger description, most importantly, as I indicated at the start, please
indicate what are the constituents that represent the last index of the
aerfld array. In other words, which is organic carbon, sulfates,
sea-salts, etc. And, if any of them are size-bin such as dust, please
specify something about the range of the bins. This will greatly help
others, particularly me when anyone else wants to discuss adopting the T-E
scheme to another aerosol dataset. Thank you.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKNRHJ2MN3I4EPFHQLWAYCKZANCNFSM6AAAAAAQOT3BBE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@AnningCheng-NOAA @ChunxiZhang-NOAA Perhaps this is a problem with Github, but I did not see the new comment from late yesterday added into the code itself. I even refreshed the When I directly view the commit tag |
@gthompsnWRF Sorry for that. The PR commit process had started when your latest comment showed up (It took more than one day). We will add the detailed description and combine with other PR. |
@ChunxiZhang-NOAA The additional documentation was added in 9009159. |
@grantfirl Thank you Grant! |
move setting of flag from run to init phase
All credit for code changes and description to Anning Cheng.
MERRA2 climatological aerosols are used to calculate number concentrations of ice friendly and liquid friendly aerosols. IN and CCN can be activated by using aerosols. The indirect interactions of aerosols and clouds are expected to happen. This PR is created to replace the NCAR/ccpp-physics PR#720, which was created by Anning Cheng.
The MERRA2 coupled Thompson (EXP MRAERO) shows improvement from the control run and the forecasted NIFA and NWFA approach (LTAERO), specially decreased cloud water bias as shown in the attached poster. More comprehensive comparison located at https://www.emc.ncep.noaa.gov/gmb/acheng/mraero/.
Because the GOCART coupled Thompson scheme shares the same IN/CCN activation module as the MERRA2 coupled Thompson scheme, we expect more improvements. Some results can be found here:
gass_3_v1.pdf