-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate csawMG update and pass both intel and GNU RT tests #2180
Conversation
I'm running RTs on Hera now. I'll upload logs when finished. |
@grantfirl I think we're ready to begin testing this PR. Can you please sync up your branch? |
@zach1221 Finished syncing. |
Fernando and I are getting failures with the debug cases on Hera and orion, control_csawmg_debug and control_csawmgt_debug, both intel and gnu. Err log has: "subscript #2 of the array SIGMA has value 128 which is greater than the upper bound of 127" /work/noaa/stmp/zshrader/stmp/zshrader/FV3_RT/rt_279127/control_csawmgt_debug_intel |
Not sure why the err did not come with my run, but i n cs_conv.meta, please
change from
[sigma]
standard_name = convective_updraft_area_fraction_at_model_interfaces
long_name = convective updraft area fraction at model interfaces
units = frac
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
intent = out
to
...
dimensions = (horizontal_loop_extent,vertical_layer_dimension+1)
...
…On Tue, Mar 12, 2024 at 5:42 PM zach1221 ***@***.***> wrote:
Fernando and I are getting failures with the debug cases on Hera and
orion, control_csawmg_debug and control_csawmgt_debug, both intel and gnu.
Err log has: "subscript #2
<#2> of the
array SIGMA has value 128 which is greater than the upper bound of 127"
/work/noaa/stmp/zshrader/stmp/zshrader/FV3_RT/rt_279127/control_csawmgt_debug_intel
—
Reply to this email directly, view it on GitHub
<#2180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJBSFBXLSW75WDYEBLYX5ZFRAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGYZTKOBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@grantfirl are you able to make the changes mentioned above? |
WCOSS2:
and
|
"vertical_interface_dimension" should have been used instead of
"vertical_layer_dimension" in cs_conv.meta, cs_conv_post.meta, and
FV3/ccpp/data/CCPP_typedefs.meta as :
[sigma] (sigmatot in cs_conv_post.meta and
FV3/ccpp/data/CCPP_typedefs.meta)
standard_name = convective_updraft_area_fraction_at_model_interfaces
long_name = convective updraft area fraction at model interfaces
units = frac
dimensions = (horizontal_loop_extent,vertical_interface_dimension)
The err should be fixed now.
…On Tue, Mar 12, 2024 at 10:04 PM Brian Curtis ***@***.***> wrote:
WCOSS2:
Found Python: /usr/bin/python3.6
Calling CCPP code generator (ccpp_prebuild.py) for suites --suites=FV3_GFS_v16_csawmg,FV3_GFS_v16_ras ...
CMake Error at FV3/ccpp/CMakeLists.txt:40 (message):
An error occured while running ccpp_prebuild.py, check
/lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_169315/compile_csawmg_intel/build_fv3_csawmg_intel/FV3/ccpp/ccp
p_prebuild.{out,err}
and
Calling CCPP code generator (ccpp_prebuild.py) for suites --suites=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta,FV3_HRRR_c3,FV3_HRRR_gf,FV3_global_nest_v1 ...
CMake Error at FV3/ccpp/CMakeLists.txt:40 (message):
An error occured while running ccpp_prebuild.py, check
/lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_169315/compile_atm_debug_dyn32_intel/build_fv3_atm_debug_dyn32_intel/FV3/ccpp/ccpp_prebuild.{out,err}
—
Reply to this email directly, view it on GitHub
<#2180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOGJXZOJTGSK4YTKIDYX6X3TAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGEYTGNJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@AnningCheng-NOAA You mean a fix is needed (replace vertical_layer_dimension with vertical_interface_dimension) at https://github.com/NOAA-EMC/fv3atm/blob/062f7958ccd9bd97b8737432f75b06ec734777a7/ccpp/data/CCPP_typedefs.meta#L1955 ? @grantfirl @zach1221 @FernandoAndrade-NOAA FYI |
Yes. Could you make the changes accordingly?
…On Wed, Mar 13, 2024 at 8:35 AM JONG KIM ***@***.***> wrote:
"vertical_interface_dimension" should have been used instead of
"vertical_layer_dimension" in cs_conv.meta, cs_conv_post.meta, and
FV3/ccpp/data/CCPP_typedefs.meta as : [sigma] (sigmatot in
cs_conv_post.meta and FV3/ccpp/data/CCPP_typedefs.meta) standard_name =
convective_updraft_area_fraction_at_model_interfaces long_name = convective
updraft area fraction at model interfaces units = frac dimensions =
(horizontal_loop_extent,vertical_interface_dimension) The err should be
fixed now.
… <#m_-6610151748954881695_>
On Tue, Mar 12, 2024 at 10:04 PM Brian Curtis *@*.*> wrote: WCOSS2: Found
Python: /usr/bin/python3.6 Calling CCPP code generator (ccpp_prebuild.py)
for suites --suites=FV3_GFS_v16_csawmg,FV3_GFS_v16_ras ... CMake Error at
FV3/ccpp/CMakeLists.txt:40 (message): An error occured while running
ccpp_prebuild.py, check
/lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_169315/compile_csawmg_intel/build_fv3_csawmg_intel/FV3/ccpp/ccp
p_prebuild.{out,err} and Calling CCPP code generator (ccpp_prebuild.py) for
suites
--suites=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta,FV3_HRRR_c3,FV3_HRRR_gf,FV3_global_nest_v1
... CMake Error at FV3/ccpp/CMakeLists.txt:40 (message): An error occured
while running ccpp_prebuild.py, check
/lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_169315/compile_atm_debug_dyn32_intel/build_fv3_atm_debug_dyn32_intel/FV3/ccpp/ccpp_prebuild.{out,err}
— Reply to this email directly, view it on GitHub <#2180 (comment)
<#2180 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQPMIOGJXZOJTGSK4YTKIDYX6X3TAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGEYTGNJVG4
<https://github.com/notifications/unsubscribe-auth/ALQPMIOGJXZOJTGSK4YTKIDYX6X3TAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGEYTGNJVG4>
. You are receiving this because you were mentioned.Message ID: @.*>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> You mean a fix is
needed (replace vertical_layer_dimension with vertical_interface_dimension)
at
https://github.com/NOAA-EMC/fv3atm/blob/062f7958ccd9bd97b8737432f75b06ec734777a7/ccpp/data/CCPP_typedefs.meta#L1955
? @grantfirl <https://github.com/grantfirl> @zach1221
<https://github.com/zach1221> @FernandoAndrade-NOAA
<https://github.com/FernandoAndrade-NOAA> FYI
—
Reply to this email directly, view it on GitHub
<#2180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMII4IFGARCLVNPL2C3TYYBB2JAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGI4TEOBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@grantfirl following up here, could you please make the additional changes or provide Jong/myself permission to commit directly to the repo? |
"vertical_layer_dimension+1" causes compilation error and please use
"vertical_interface_dimension"
in cs_conv.meta and cs_conv_post.meta for "sigma" and "sigmatot",
respectively.
…On Wed, Mar 13, 2024 at 9:16 AM zach1221 ***@***.***> wrote:
@grantfirl <https://github.com/grantfirl> following up here, could you
please make the additional changes or provide Jong/myself permission to
commit directly to the repo?
—
Reply to this email directly, view it on GitHub
<#2180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIM4ZIWHOEHRHWFC4VLYYBGRPAVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGM4DGMJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, I'll make that change. Stand by. |
@zach1221 @AnningCheng-NOAA @jkbk2004 The change has been made and tests should be ready to resume. |
Awesome, thank you so much!
…On Wed, Mar 13, 2024 at 10:14 AM Grant Firl ***@***.***> wrote:
@zach1221 <https://github.com/zach1221> @AnningCheng-NOAA
<https://github.com/AnningCheng-NOAA> @jkbk2004
<https://github.com/jkbk2004> The change has been made and tests should
be ready to resume.
—
Reply to this email directly, view it on GitHub
<#2180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOJ3EGOCKMKO6L73P3YYBNM7AVCNFSM6AAAAABELUFRCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGUYDKMBRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@BrianCurtis-NOAA Could you post the error written out to ccpp_prebuild.err in those instances? |
I know Anning addressed the issue that showed up there, but I will definitely gather that files output if I see ccpp_physics build issues in the future. Thanks. |
@grantfirl testing is complete here, we can begin the merging process. |
Thanks, @zach1221 . I've asked the other reviewers to review again via email, in case the GitHub emails get lost in their inboxes (which often happens if you watch many repos). Worst case scenario, if we can't get an approval, I can force a merge. It is mostly Anning's work and I just did some cleaning up, so I'm somewhat impartial enough to review. |
@grantfirl fv3atm pr is merged. hash: NOAA-EMC/fv3atm@21744e2 |
Commit Queue Requirements:
Description:
This is work from @AnningCheng-NOAA. This replaces #2130 for convenience of testing/updating/merging.
CSAW missed a major update and cannot pass RTs for GNU compiler. Both are fixed in this PR
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: