-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce positive-definite TVD methods for PBL and cumulus convective schemes #858
Conversation
@rmontuoro please bring these up to date with respective authoritative repositories
|
1 similar comment
@rmontuoro please bring these up to date with respective authoritative repositories
|
@rmontuoro would you please fix the format change requested by the reviewer in your ccpp physics PR #753? |
Automated RT Failure Notification |
Automated RT Failure Notification |
@rmontuoro please also change the BL_DATE in rt.sh to 20211108 for the new baseline. |
@junwang-noaa I think we are ready to create new baselines. I'll add the hera-intel/gnu BL labels. |
I am running RT on dell and cray. |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR introduces positive-definite Total Variation Diminishing (TVD) mass-flux methods recently developed at NOAA/EMC (Jongil Han) to improve tracer transport in EDMF-TKE PBL schemes and SAMF cumulus convective parameterizations.
Such methods do not generate negative values for tracer mixing ratios during convective transport. The updated code may still generate very small (
1.E-15
) negative values during PBL mixing.Please see ccpp-physics issue #753 and associated PR #754 for additional information.
Issue(s) addressed
Testing
The changes were tested on Hera/Intel and Orion/Intel.
Preliminary regression tests were run on Hera/Intel. Note that this PR will change the regression test baseline.
Dependencies