fix: Fixed bug with placeholder (#114)

uiwjs · Apr 26, 2022 · d7a4df2 · d7a4df2
1 parent 9288db6
commit d7a4df2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/index.tsx b/src/index.tsx
@@ -45,7 +45,10 @@ export default React.forwardRef<HTMLTextAreaElement, TextareaCodeEditorProps>((p
   } = props;
 
   const [value, setValue] = useState(props.value || '');
-  useEffect(() => setValue(props.value || ''), [props.value]);
+  useEffect(
+    () => setValue(props.value || ''),
+    [props.value]
+  );
   const textRef = useRef<HTMLTextAreaElement>(null);
   useImperativeHandle<HTMLTextAreaElement, HTMLTextAreaElement>(ref, () => textRef.current!);
 
@@ -59,12 +62,12 @@ export default React.forwardRef<HTMLTextAreaElement, TextareaCodeEditorProps>((p
   const htmlStr = useMemo(
     () =>
       processHtml(
-        `<pre aria-hidden=true><code ${language ? `class="language-${language}"` : ''} >${htmlEncode(
-          String(value || ''),
+        `<pre aria-hidden=true><code ${language && value ? `class="language-${language}"` : ''} >${htmlEncode(
+          String(value || placeholder || ''),
         )}</code><br /></pre>`,
         rehypePlugins,
       ),
-    [value, language, rehypePlugins],
+    [value, placeholder, language, rehypePlugins],
   );
   const preView = useMemo(
     () => (

diff --git a/website/App.tsx b/website/App.tsx
@@ -74,6 +74,15 @@ const App: React.FC = () => {
           onChange={(evn) => setCode(evn.target.value)}
         />
       </div>
+      <div className="App-editor">
+        <span>Test case</span>
+        <div style={{ display: 'flex', flexDirection: 'row', marginTop: 12 }}>
+          <TextareaCodeEditor placeholder={`Please enter ${(language || '').toLocaleUpperCase()} code.`} />
+          <button type="button" style={{ marginLeft: 12 }}>
+            Edit
+          </button>
+        </div>
+      </div>
       <div className="App-tools" style={{ marginTop: 5 }}>
         <select value={language} onChange={(evn) => setLanguage(evn.target.value)}>
           {exts.map((keyName, idx) => {