Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with placeholder #114

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Fixed bug with placeholder #114

merged 2 commits into from
Apr 26, 2022

Conversation

nikelborm
Copy link
Contributor

Bug:

When placeholder is provided and there is no value, placeholder renders fine in the textarea, but it does not render in the preview.

@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for vibrant-wilson-a6f337 ready!

Name Link
🔨 Latest commit 49e3310
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-wilson-a6f337/deploys/6267a9388994d60008fb7b5c
😎 Deploy Preview https://deploy-preview-114--vibrant-wilson-a6f337.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaywcjlove
Copy link
Member

image

@nikelborm This is a function that comes with the html <textarea> tag, and there will be no bugs.
There may be style conflicts.

I tested and there are no bugs

@nikelborm
Copy link
Contributor Author

nikelborm commented Apr 26, 2022

Ahah, I found where was the problem

I didn't see the placeholder because my parent component is display:flex and it squeeze code editor

Screenshot_20220426_105200

Screenshot_20220426_105326

But when I disabled flex it works fine

What should we do with this?
In this flex case I think this manual setting of placeholder will be still usefull

@nikelborm
Copy link
Contributor Author

nikelborm commented Apr 26, 2022

Check my last commit with 49e3310#diff-f87270b29523717f9e20dac3310b24d5bf58c893da983f8df0745ae3179c45a0R79

If I remove this placeholder fix from here d305a98#diff-0b5adbfe7b36e4ae2f479291e20152e33e940f7f265162d77f40f6bdb5da7405R65

My test case will look like this
Screenshot_20220426_111619

@nikelborm
Copy link
Contributor Author

With fix enabled it will look like this

Screenshot_20220426_111826

@jaywcjlove jaywcjlove merged commit d7a4df2 into uiwjs:main Apr 26, 2022
@jaywcjlove
Copy link
Member

One line short code code, this usage is rare, but it convinced me.
@nikelborm

jaywcjlove added a commit that referenced this pull request Apr 30, 2022
github-actions bot pushed a commit that referenced this pull request Apr 30, 2022
jaywcjlove added a commit that referenced this pull request Nov 7, 2022
github-actions bot pushed a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants