Firebreak/data hub test data contacts #5348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| redis = Redis.from_url(settings.REDIS_BASE_URL) | ||
| workers = Worker.all(connection=redis) | ||
| queue_names = reduce(concat, [worker.queue_names() for worker in workers], []) | ||
| missing_queues = set([queue]) - set(queue_names) |
There was a problem hiding this comment.
Suggested change
| missing_queues = set([queue]) - set(queue_names) | |
| missing_queues = {queue} - set(queue_names) |
Using set literal syntax is simpler and computationally quicker. More info.
* Create Command for rq health check and include in docker-compose.yml configuration.
* Change logging to ASIM formatter * Update common_logging.py
bau123
force-pushed
the
firebreak/data-hub-test-data-contacts
branch
from
5faaa7d to
8794031
Compare
| redis = Redis.from_url(settings.REDIS_BASE_URL) | ||
| workers = Worker.all(connection=redis) | ||
| queue_names = reduce(concat, [worker.queue_names() for worker in workers], []) | ||
| missing_queues = set([queue]) - set(queue_names) |
There was a problem hiding this comment.
Suggested change
| missing_queues = set([queue]) - set(queue_names) | |
| missing_queues = {queue} - set(queue_names) |
Using set literal syntax is simpler and computationally quicker. More info.
bau123
force-pushed
the
firebreak/data-hub-test-data-contacts
branch
from
8794031 to
c3fff3d
Compare
create a batch of contact records based on advisers
bau123
force-pushed
the
firebreak/data-hub-test-data-contacts
branch
from
c3fff3d to
1c3c20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generator for contacts
Checklist
Has this branch been rebased on top of the current
mainbranch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yamlis maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.