Use correct listenAddress for Karma on node 18+ #13968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
From Node.js 17 DNS resolution is different, causing the Karma server to listen to the wrong address by default. This breaks Umbraco's gulp test tasks and default gulp build.
Telling the karma server to listen on
::
fixes the problem - as per the issue on the Karma repo. This change is backwards compatible down to (at least) Node.js v14 so doesn't change version requirements for Umbraco 🎉To test: run
gulp build
from/src/Umbraco.Web.UI.Client
on any version from Node.js from 14+I've tested on 14, 16, 18 and 19
Once this is merged, it would be worth checking if HQ can bump the Node.js version in the pipelines to latest LTS.