Add UsePagedSqlQuery setting to NucacheSettings #14806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13525
Notes
UsePagedSqlQuery
inNuCacheSettings
, that can now be set tofalse
, to instead useFetch
IOptionsMonitor
instead to track changes, but we cannot refactor this to be non-breaking (even withActivatorUtilitiesConstructor
), as the constructors will be ambiguous 😢How to test
UsePagedSqlQuery
to false:You can even test the times by cherry picking this Profiling PR in: #13841
and testing with the setting both set to false & true