Fixing regression bug introduced in #14806

[wtct]

Fixing regression bug introduced in #14806 and found during investigation of #16803 - well tested on db with 300k+ nodes

Prerequisites

Description

Fixing regression bug introduced in #14806 and found during investigation of #16803 - well tested on db with 300k+ nodes

Please consider merging this PR as a quick fix for bug introduced in the #14806 by @Zeegaan.

There is lack of the WHERE clause in the sql count queries.

It has massive impact on publish/unpublish operations in Umbraco instances with huge amount of content.

In our case it's not possible to use the CMS by editors after upgrading to the 13.4.1.

[github-actions]

Hi there @wtct, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[georgebid]

Thanks for the PR to fix this bug @wtct, someone on the core collaborators team will review this soon, although, it may be helpful if @Zeegaan takes a look, as I expect you'll be most familiar with this change 😺

[piotrbach]

Hi @georgebid, we have double-checked the code and can confirm that it works correctly🎉.

Do you conduct performance testing before releases🤔?
The issue seems to go unnoticed with a small number of documents but becomes significant as the dataset grows.
It's surprising that this obvious bug is being reported only now, considering it affects projects from versions 10, 13, and 14.
With over 300,000 records, the CMS becomes unusable for editors.

I hope this PR gets approved soon🙏🤠, as it is blocking our key project.
Btw. Referring to this blog post on Umbraco performance issues might speed up the review.

cc: @wtct @Zeegaan

[Zeegaan]

Thanks for this contribution, and the write up around it 😁
Looks good, tests good 🚀

[piotrbach]

Hi @Zeegaan no problem!
Btw. When can we expect the release of fixed v13, so we can update our project?
This fix is critical for us🙏.
@wtct

[Zeegaan]

We have a few other issues we are in the process of fixing for v13, so can't really give a precise timeline unfortunately.

So I would say hopefully in the next 2 weeks time, but I cannot promise anything 😁

[wtct]

@Zeegaan Maybe it's worth considering releasing a new version just with this fix, because it's a critical issue?

[nul800sebastiaan]

Cherry-picked for v13 in 2736a51

[OwainJ]

Just hit this issue trying to migrate 200k nodes into a new v13 site 😬 if this could be released as a patch to 13.4, as 13.5 is 2+ weeks away, I would be eternally grateful!! 🙏

Edit: We ended up using the nightly build, as suggested by Umbraco support:
https://docs.umbraco.com/umbraco-cms/fundamentals/setup/install/installing-nightly-builds

[piotrbach]

Hi @georgebid @Zeegaan @nul800sebastiaan, sorry to bother you again.
I was wondering if there's any update or an estimated release date for the fixed version of v13?
Thanks in advance🤝

@wtct

[Zeegaan]

Yes but it's not good news unfortunately, its gonna be around the beginning of September 😁
However, if you really need this patch for your project, you can always use a nightly build 💪
https://docs.umbraco.com/umbraco-cms/fundamentals/setup/install/installing-nightly-builds

[prjseal]

Cherry-picked for v13 in 2736a51

Hi Seb,

Would you be able to cherry pick this for v10 too please? We are experiencing this on one of our Umbraco Cloud v10 sites and v10 is also LTS isn't it?

Kind regards

Paul

[RosenPetrovFFW]

I am also looking after the release of version 13.5.0. 53k nodes in the project and we are impacted by this problem, too.

[RosenPetrovFFW]

Sebastiaan replied to me that probably later today 13.5.0 would be released!

[wtct]

Cherry-picked for v13 in 2736a51

Hi @nul800sebastiaan,

Please take into account that this issue has been introduced in the v10.8.0 during the security phase after the support phase as we can see here:

https://umbraco.com/products/knowledge-center/long-term-support-and-end-of-life/

https://our.umbraco.com/download/releases/1081 (Released on Tuesday, December 12 2023)
https://our.umbraco.com/download/releases/1080 (released between 10.7.0 and 10.8.1)
https://our.umbraco.com/download/releases/1070 (Released on Thursday, September 7 2023)

So now we have to decide if we want to upgrade to the secure version or stay with the efficient one (10.7.0), or even go for 13.5.2 what could be challenging in projects.

Could you please consider merging this PR to v10 and prepare another release?

Thanks in advance!

Best!

cc: @piotrbach

[nul800sebastiaan]

@wtct Unfortunately I can't help you here:

• The performance issue [was introduced]Add UsePagedSqlQuery setting to NucacheSettings #14806) on Sep 14, 2023 - v10 was in Support Phase
• You reported performance issues on Jul 19 2024, v10 was in Security Phase
• You provided a PR on Jul 29 2024, v10 was in Security Phase

Since we're not delivering any more releases for v10 except for security updates, we recommend you upgrade to v13 instead.