Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show BlockGrid Create Dialog if there are items in clipboard #15841

Conversation

stefanstankovic
Copy link

Default behavior:

If you have only one available module for an area Umbraco will open a dialog for adding the module. If you have more than one module you will get a dialog to choose a module and that dialog will have a Paste option in the top right corner.

New behavior:

If there is a module in the clipboard, Umbraco will open a dialog with the Paste option even thou there is only one available module in the area. In other cases, it will work as usual.

Reported issue: #15755

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Default behavior:

If you have only one available module for an area Umbraco will
open a dialog for adding the module. If you have more than one
module you will get a dialog to choose a module and that dialog
will have a Paste option in the top right corner.

New behavior:

If there is a module in the clipboard, Umbraco will open a dialog
with the Paste option even thou there is only one available module
in the area. In other cases, it will work as usual.

Reported issue: umbraco#15755
Copy link

github-actions bot commented Mar 5, 2024

Hi there @stefanstankovic, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Mar 5, 2024

Hi @stefanstankovic ,

Thanks for spotting this issue and providing the fix 👍
A member of the core collaborators team will have a look at it soon, butI already took the action of rebasing your PR on the contrib branch which is the only one that the community contributors are supposed to target. The other branches being reserved to HQ 😉

Cheers!

@mikecp mikecp changed the base branch from v13/dev to contrib March 5, 2024 23:50
@mikecp
Copy link
Contributor

mikecp commented Mar 10, 2024

Hi @stefanstankovic ,

I have just checked your update and it works as expected, enabling consistency in all cases 👍
Thanks a lot for your PR, I see this is your first one on the Umbraco CMS, congratulations!! 🎉
If you provide us with your account name on the forum (Our), I am sure that our steward @nul800sebastiaan will be very happy to assign our shiny contributor's badge to you 🏅

Thanks again, and we'll be looking forward to your next contributions 😉

Cheers!

@mikecp mikecp merged commit d97cbf4 into umbraco:contrib Mar 10, 2024
14 of 16 checks passed
@mikecp
Copy link
Contributor

mikecp commented Mar 10, 2024

Oh and I have added the bellissima label so that HQ can make sure that this is handled on V14 as well 😁

@Migaroez
Copy link
Contributor

@stefanstankovic Just wanted to throw another big thank you your way. It's because of people like you that the CMS is flourishing as it is!

@Migaroez Migaroez added the status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0). label Mar 27, 2024
Migaroez added a commit that referenced this pull request Mar 27, 2024
# Conflicts:
#	src/Umbraco.Infrastructure/PropertyEditors/MultiUrlPickerValueEditor.cs
#	src/Umbraco.Web.Common/Profiler/WebProfiler.cs
#	src/Umbraco.Web.UI.Client/package-lock.json
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valpropertymsg.directive.js
#	src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.controller.js
#	src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.html
#	src/Umbraco.Web.UI.Client/src/views/content/content.create.controller.js
#	src/Umbraco.Web.UI.Client/src/views/content/create.html
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbBlockGridPropertyEditor.component.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.controller.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.html
#	src/Umbraco.Web.UI.Client~HEAD

# Ignored changes
#  #14787
#  #15853
#  #15841
@stefanstankovic
Copy link
Author

@mikecp I'm sorry for the late response. My forum account is: https://our.umbraco.com/members/stefanstankovic/

@stefanstankovic stefanstankovic deleted the v13/fix/block-grid-property-editor-show-create branch April 22, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/ux User experience community/pr project/bellissima AKA "the new backoffice" release/13.3.0 status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0). type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants