-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show BlockGrid Create Dialog if there are items in clipboard #15841
Show BlockGrid Create Dialog if there are items in clipboard #15841
Conversation
Default behavior: If you have only one available module for an area Umbraco will open a dialog for adding the module. If you have more than one module you will get a dialog to choose a module and that dialog will have a Paste option in the top right corner. New behavior: If there is a module in the clipboard, Umbraco will open a dialog with the Paste option even thou there is only one available module in the area. In other cases, it will work as usual. Reported issue: umbraco#15755
Hi there @stefanstankovic, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @stefanstankovic , Thanks for spotting this issue and providing the fix 👍 Cheers! |
Hi @stefanstankovic , I have just checked your update and it works as expected, enabling consistency in all cases 👍 Thanks again, and we'll be looking forward to your next contributions 😉 Cheers! |
Oh and I have added the bellissima label so that HQ can make sure that this is handled on V14 as well 😁 |
@stefanstankovic Just wanted to throw another big thank you your way. It's because of people like you that the CMS is flourishing as it is! |
# Conflicts: # src/Umbraco.Infrastructure/PropertyEditors/MultiUrlPickerValueEditor.cs # src/Umbraco.Web.Common/Profiler/WebProfiler.cs # src/Umbraco.Web.UI.Client/package-lock.json # src/Umbraco.Web.UI.Client/src/common/directives/validation/valpropertymsg.directive.js # src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.controller.js # src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.html # src/Umbraco.Web.UI.Client/src/views/content/content.create.controller.js # src/Umbraco.Web.UI.Client/src/views/content/create.html # src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbBlockGridPropertyEditor.component.js # src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.controller.js # src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.html # src/Umbraco.Web.UI.Client~HEAD # Ignored changes # #14787 # #15853 # #15841
@mikecp I'm sorry for the late response. My forum account is: https://our.umbraco.com/members/stefanstankovic/ |
Default behavior:
If you have only one available module for an area Umbraco will open a dialog for adding the module. If you have more than one module you will get a dialog to choose a module and that dialog will have a Paste option in the top right corner.
New behavior:
If there is a module in the clipboard, Umbraco will open a dialog with the Paste option even thou there is only one available module in the area. In other cases, it will work as usual.
Reported issue: #15755
Prerequisites
If there's an existing issue for this PR then this fixes
Description