Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for the runtime mode and showed the relevant error mess… #15853

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Added a check for the runtime mode and showed the relevant error mess… #15853

merged 1 commit into from
Mar 8, 2024

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Mar 7, 2024

…age if

Prerequisites

  • I have added steps to test this contribution in the description below

This fixes the PR raised by @marcemarc

Fixes #15758

So now with this PR, when in Production Mode, instead of showing this:

image

We now show this:

image

Copy link

github-actions bot commented Mar 7, 2024

Hi there @prjseal, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Mar 8, 2024

Hello @prjseal,

Thanks for this fix, it will be indeed clearer like this 😉
Someone from the core collaborators team will have a look at it soon.

Cheers!

@busrasengul
Copy link
Contributor

I tested this and it's good to merge!

@busrasengul busrasengul merged commit 7813acf into umbraco:contrib Mar 8, 2024
14 checks passed
@busrasengul busrasengul self-assigned this Mar 8, 2024
@Migaroez Migaroez added the status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0). label Mar 27, 2024
Migaroez added a commit that referenced this pull request Mar 27, 2024
# Conflicts:
#	src/Umbraco.Infrastructure/PropertyEditors/MultiUrlPickerValueEditor.cs
#	src/Umbraco.Web.Common/Profiler/WebProfiler.cs
#	src/Umbraco.Web.UI.Client/package-lock.json
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valpropertymsg.directive.js
#	src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.controller.js
#	src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.html
#	src/Umbraco.Web.UI.Client/src/views/content/content.create.controller.js
#	src/Umbraco.Web.UI.Client/src/views/content/create.html
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbBlockGridPropertyEditor.component.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.controller.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.html
#	src/Umbraco.Web.UI.Client~HEAD

# Ignored changes
#  #14787
#  #15853
#  #15841
@iOvergaard iOvergaard added the project/bellissima AKA "the new backoffice" label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend category/ui User interface community/pr project/bellissima AKA "the new backoffice" status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0). type/improvement
Projects
None yet
5 participants