Return 404 instead of 500 when an "original parent" has been deleted #15990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The API explicitly returns a 500 response code if the "original parent" of a "restore from recycle bin" attempt is not found:
This seems very dramatic 😄 specially since this is a normal, expected scenario; the "original parent" has simply been deleted from the recycle bin, before the attempt to restore the previous child is made.
This PR changes the response code to be a 404 instead. Less dramatic 😛
Testing this PR
/umbraco/management/api/v1/recycle-bin/document/{key}/original-parent
.Rinse and repeat for media.
Note that "move to recycle bin" and "delete" operations are currently only functional through the API (in other words, use Swagger).