Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 instead of 500 when an "original parent" has been deleted #15990

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Return 404 instead of 500 when an "original parent" has been deleted #15990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Umbraco.Cms.Api.Management/Controllers/RecycleBin/RecycleBinControllerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ protected IActionResult MapRecycleBinQueryAttemptFailure(RecycleBinQueryResultTy
.WithTitle($"The {contentType} is not trashed")
.WithDetail($"The {contentType} needs to be trashed for the parent-before-recycled relation to be created.")
.Build()),
RecycleBinQueryResultType.NoParentRecycleRelation => StatusCode(StatusCodes.Status500InternalServerError, problemDetailsBuilder
RecycleBinQueryResultType.NoParentRecycleRelation => NotFound(problemDetailsBuilder
.WithTitle("The parent relation could not be found")
.WithDetail($"The relation between the parent and the {contentType} that should have been created when the {contentType} was deleted could not be found.")
.Build()),
Expand Down
Loading