Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 External login linking + Proposed error handling #16052

Merged
merged 5 commits into from
Apr 16, 2024

Transformed the OAuthOptionsExtensions into a helper class

e4835fe
Select commit
Loading
Failed to load commit list.
Merged

V14 External login linking + Proposed error handling #16052

Transformed the OAuthOptionsExtensions into a helper class
e4835fe
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev) succeeded Apr 16, 2024 in 1m 4s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

Annotations

Check notice on line 61 in src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

ℹ Getting worse: Constructor Over-Injection 

BackOfficeController increases from 7 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis