Explicit endpoints returning the Login and BackOffice logos and background #17696
Conversation
…ng the configuration. Thereby some hardcoded values have been changed, but the url will now be the same every time.
There was a problem hiding this comment.
It is indeed not possible to use Url.Action() to find the correct route, most likely because we overwrite the controller route part and the url helper doesn't take this into account?
I moved the concatenation into an explicit const so it can be referenced directly from the view instead of having to duplicate the concatenation.
Feel free to merge if you are happy with the change when the tests complete.
src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-header-logo.element.ts
Outdated
Show resolved
Hide resolved
…hanging-background-on-login-everywhere
…o the backoffice
…o the login screen
…em from the login project
…logo "mark" used throughout all applications
There was a problem hiding this comment.
I have created a new "logo" endpoint with the logomark logo used in the backoffice and other places and consequently updated the backoffice-logo element to use the new logo endpoint including added a new setting for the path. NoNodes is also updated as well as the "disabled javascript" warnings.
Added mock handlers for the new endpoints in both UI projects (Backoffice and Login).
Cleaned up (now-)unused assets so that image assets are placed in src/Umbraco.CMS.StaticAssets/wwwroot/umbraco/assets resembling what we had with the old backoffice. These new endpoints enable us to be able to replace all assets in one place.
…ding server url and appropriate tags
…e to add the serverUrl in front of other graphics
…hanging-background-on-login-everywhere
iOvergaard
changed the title
bergmania
deleted the
v15/bugfix/allow-changing-background-on-login-everywhere
branch
Description
Fixes #16636
Fixes #17441
Introduces four new endpoints that are not exposed in management api, as they are only for backoffice.
/umbraco/management/api/v1/security/back-office/graphics/login-background/umbraco/management/api/v1/security/back-office/graphics/logo/umbraco/management/api/v1/security/back-office/graphics/login-logo/umbraco/management/api/v1/security/back-office/graphics/login-logo-alternativeUpdated usages of the ContentSettings.* to use these new endpoints and updated the hardcoded paths to point to these new endpoints.
Updated the backoffice-logo element to use the new logo endpoint including added a new setting for the path.
Added mock handlers for the new endpoints in both UI projects (Backoffice and Login).
Cleaned up (now-)unused assets so that image assets are placed in
src/Umbraco.CMS.StaticAssets/wwwroot/umbraco/assetsresembling what we had with the old backoffice. These new endpoints enable us to be able to replace all assets in one place.Tests