Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace paths, so they are equal on every OS #18071

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jan 22, 2025

Notes

  • Fixes an issue, where you could not get the logos on windows.
    This was because of the newly introduced Explicit endpoints returning the Login and BackOffice logos and background #17696. Which uses Path.Combine, which in turn on windows, combines paths with \, but all our static paths are /.
    • Note: The jumbled path works with Physical Files, but as when we ship this, its in an RCL, it does not work with that.
  • This PR remedies that by just not using Path.Combine, and instead just having the / in there always

How to test

  • Run the backoffice, you should still see the Logos
  • You can also pack the project, and run the template to make sure its still there.

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tests good 👍

@nikolajlauridsen nikolajlauridsen merged commit 0562757 into release/15.2 Jan 22, 2025
27 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v15/hotfix/fix-logo-paths-on-windows branch January 22, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants