Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arabic language #2406

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Added arabic language #2406

merged 2 commits into from
Oct 4, 2024

Conversation

bergmania
Copy link
Member

Description

Added a arabic language file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Official support of arabic, so people do not need to install a package.

How to test?

Go to you user and change the language. Verify arabic is available.

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@IbrahimMNada
Copy link
Contributor

As An Arabian and Arabic native speaker with tech/Umbraco background I would love to help review it.

if you don't mind

@nielslyngsoe
Copy link
Member

Hi @IbrahimMNada

That would be very appreciated — I have approved and merged this PR, as it works.

But I have no way to confirm the actual translation, so that would be nice to adjust so it makes sense for the Arabic users.
So please apply any changes in additional PRs.

Thanks in advance.

@nielslyngsoe nielslyngsoe merged commit 54864b4 into main Oct 4, 2024
9 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/add-ar-language branch October 4, 2024 06:51
@IbrahimMNada
Copy link
Contributor

#2414

Refer to this PR

@bassemelkadeem
Copy link

bassemelkadeem commented Dec 1, 2024

Nice done and great effort for supporting Arabic. but the direction must be RTL and the umbraco team must support styling for components to be also RTL it will be nice. i changed the direction using manifest for localization and the direction is applied but some components are not support direction to be RTL so please support to implement this in next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants