Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 6, 2023

Make icon names backward compatible.
And appends new icons from Lucide, which replaces existing icons.
Add legacy option for icons, so they cannot be picked in the Icon Picker.

Requires two PRs of UI Library to be handled first and upgraded to a version of UUI where that takes part:
umbraco/Umbraco.UI#629
umbraco/Umbraco.UI#649

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe mentioned this pull request Nov 6, 2023
7 tasks
…and-backwards-compatible

# Conflicts:
#	src/packages/core/property-editor/uis/tiny-mce/config/manifests.ts
#	src/packages/core/property-editor/uis/tiny-mce/manifests.ts
@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 6, 2023 13:36
@madsrasmussen
Copy link
Contributor

Now you are touching all the icons anyway, can you then move the icon-registry folder from the shared folder into the packages -> core folder?

@github-actions
Copy link

github-actions bot commented Nov 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net

Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced a few more icons (I think we got them all now) and fixed a small issue with the icon picker. LGTM.

@iOvergaard iOvergaard merged commit d64318b into main Nov 8, 2023
@iOvergaard iOvergaard deleted the feature/lucide-icons-and-backwards-compatible branch November 8, 2023 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants