Skip to content

uui-swatch: ability to overwrite displayed color with a css custom prop #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iOvergaard merged 5 commits into from
Nov 7, 2023
Merged

uui-swatch: ability to overwrite displayed color with a css custom prop #649

iOvergaard merged 5 commits into from
Nov 7, 2023

Conversation

@nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 6, 2023

Be able to give a different value than the color.

As well use a CSS Custom Property so the actual color can be dynamic towards the theme.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (Slightly, but just a little bit)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Nov 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-649.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe mentioned this pull request Nov 6, 2023
Merged
7 tasks
iOvergaard
iOvergaard requested changes Nov 7, 2023
View reviewed changes
@iOvergaard iOvergaard added the enhancement New feature or request label Nov 7, 2023
@github-actions
Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-649.westeurope.azurestaticapps.net

iOvergaard
iOvergaard requested changes Nov 7, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-649.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title ability to overwrite displayed color with a css custom prop uui-swatch: ability to overwrite displayed color with a css custom prop Nov 7, 2023
@iOvergaard iOvergaard merged commit 48db9f5 into v1/contrib Nov 7, 2023
@iOvergaard iOvergaard deleted the v1/feature/overwrite-swatch-color branch November 7, 2023 12:18
@bjarnef bjarnef mentioned this pull request Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nielslyngsoe @iOvergaard