Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov proposal list RPC endpoint broken #1627

Closed
4 tasks
adamewozniak opened this issue Nov 29, 2022 · 0 comments · Fixed by #1640
Closed
4 tasks

Gov proposal list RPC endpoint broken #1627

adamewozniak opened this issue Nov 29, 2022 · 0 comments · Fixed by #1640
Assignees
@robert-zaremba
Labels
T:Bug A regression or bug in the Umee codebase.

Comments

@adamewozniak
Copy link
Collaborator

adamewozniak commented Nov 29, 2022 •
edited
Loading

Summary of Bug

The RPC endpoint to list governance proposals is broken on canon-2 after the upgrade to v3.2.0.

Failing APIs:
https://api.emerald.canon-2.network.umee.cc/cosmos/gov/v1beta1/proposals
https://api.emerald.canon-2.network.umee.cc/cosmos/gov/v1beta1/proposals/7

Looks like it's no longer able to parse an old leverage registry proposal. We need to make sure that this does not break governance as a whole

Version

v3.2.0

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start a chain on a previous version
  2. Propose & pass a leverage registry update
  3. Upgrade the chain to v3.2.0
  4. Query umeed q gov proposals

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adamewozniak adamewozniak added T:Bug A regression or bug in the Umee codebase. P:High labels Nov 29, 2022
@toteki toteki mentioned this issue Nov 29, 2022
Closed
17 tasks
@robert-zaremba robert-zaremba self-assigned this Nov 30, 2022
@robert-zaremba robert-zaremba mentioned this issue Dec 1, 2022
Merged
17 tasks
@mergify mergify bot closed this as completed in #1640 Dec 5, 2022
mergify bot pushed a commit that referenced this issue Dec 5, 2022
@robert-zaremba
fix: leverage gov proposal migrations (#1640)
d417ed4 
## Description

closes: #1627


---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
T:Bug A regression or bug in the Umee codebase.
Projects
None yet
Milestone
No milestone
2 participants
@robert-zaremba @adamewozniak