Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gov endpoints fail to decode old leverage proposals after upgrade #1628

Closed
wants to merge 6 commits into from

Conversation

toteki
Copy link
Member

@toteki toteki commented Nov 29, 2022

Description

This will revert some file deletions from #1486 and register a concrete type - hopefully that is sufficient to fix broken endpoints.

closes: #1627


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review November 29, 2022 18:01
@toteki toteki requested a review from a team as a code owner November 29, 2022 18:01
@toteki
Copy link
Member Author

toteki commented Nov 29, 2022

Not tested yet but please have a look

@codecov-commenter
Copy link

Codecov Report

Merging #1628 (9b0c24f) into main (f468a4c) will decrease coverage by 0.19%.
The diff coverage is 9.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   54.05%   53.86%   -0.20%     
==========================================
  Files          71       72       +1     
  Lines        7150     7181      +31     
==========================================
+ Hits         3865     3868       +3     
- Misses       2988     3016      +28     
  Partials      297      297              
Impacted Files Coverage Δ
x/leverage/types/gov.go 8.00% <8.00%> (ø)
x/leverage/types/codec.go 42.85% <16.66%> (-5.42%) ⬇️

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba
Copy link
Member

We migrate gov proposals in #1640 , hence this is not needed.

@toteki toteki deleted the adam/fix-gov branch February 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gov proposal list RPC endpoint broken
4 participants